From: Andrew Jones <drjones@redhat.com>
To: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Cc: marc.zyngier@arm.com, cdall@linaro.org, pbonzini@redhat.com
Subject: [PATCH v5 11/11] KVM: arm/arm64: timer: remove request-less vcpu kick
Date: Sun, 4 Jun 2017 14:44:01 +0200 [thread overview]
Message-ID: <20170604124401.24902-12-drjones@redhat.com> (raw)
In-Reply-To: <20170604124401.24902-1-drjones@redhat.com>
The timer work is only scheduled for a VCPU when that VCPU is
blocked. This means we only need to wake it up, not kick (IPI)
it. While calling kvm_vcpu_kick() would just do the wake up,
and not kick, anyway, let's change this to avoid request-less
vcpu kicks, as they're generally not a good idea (see
"Request-less VCPU Kicks" in
Documentation/virtual/kvm/vcpu-requests.rst)
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
virt/kvm/arm/arch_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c
index 5976609ef27c..7933b1f8f7b7 100644
--- a/virt/kvm/arm/arch_timer.c
+++ b/virt/kvm/arm/arch_timer.c
@@ -95,7 +95,7 @@ static void kvm_timer_inject_irq_work(struct work_struct *work)
* If the vcpu is blocked we want to wake it up so that it will see
* the timer has expired when entering the guest.
*/
- kvm_vcpu_kick(vcpu);
+ kvm_vcpu_wake_up(vcpu);
}
static u64 kvm_timer_compute_delta(struct arch_timer_context *timer_ctx)
--
2.9.4
next prev parent reply other threads:[~2017-06-04 12:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 12:43 [PATCH v5 00/11] KVM: arm/arm64: race fixes and vcpu requests Andrew Jones
2017-06-04 12:43 ` [PATCH v5 01/11] KVM: improve arch vcpu request defining Andrew Jones
2017-06-04 12:43 ` [PATCH v5 02/11] KVM: add kvm_request_pending Andrew Jones
2017-06-04 12:43 ` [PATCH v5 03/11] KVM: Add documentation for VCPU requests Andrew Jones
2017-06-04 12:43 ` [PATCH v5 04/11] KVM: arm/arm64: properly use vcpu requests Andrew Jones
2017-06-04 14:51 ` Christoffer Dall
2017-06-04 12:43 ` [PATCH v5 05/11] KVM: arm/arm64: replace pause checks with vcpu request checks Andrew Jones
2017-06-04 12:43 ` [PATCH v5 06/11] KVM: arm/arm64: use vcpu requests for power_off Andrew Jones
2017-06-04 12:43 ` [PATCH v5 07/11] KVM: arm/arm64: optimize VCPU RUN Andrew Jones
2017-06-04 12:43 ` [PATCH v5 08/11] KVM: arm/arm64: change exit request to sleep request Andrew Jones
2017-06-04 12:43 ` [PATCH v5 09/11] KVM: arm/arm64: use vcpu requests for irq injection Andrew Jones
2017-06-04 12:44 ` [PATCH v5 10/11] KVM: arm/arm64: PMU: remove request-less vcpu kick Andrew Jones
2017-06-04 12:44 ` Andrew Jones [this message]
2017-06-04 14:52 ` [PATCH v5 11/11] KVM: arm/arm64: timer: " Christoffer Dall
2017-06-04 14:56 ` [PATCH v5 00/11] KVM: arm/arm64: race fixes and vcpu requests Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604124401.24902-12-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=cdall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox