From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Storozhenko Subject: Re: [PATCH] KVM: Replaces 'unsigned' with 'unsigned int' in the codebase Date: Tue, 27 Jun 2017 16:31:11 +0300 Message-ID: <20170627133111.GB21666@home> References: <20170627095401.GA19864@home> <9b50ee4b-d27a-8872-0cd3-cad8f5f0e0f8@redhat.com> <20170627120626.GA21666@home> <1498566090.24295.59.camel@perches.com> Reply-To: 'Roman Storozhenko , '@home Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D513440D59 for ; Tue, 27 Jun 2017 09:31:10 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HWvTrPaG8nBW for ; Tue, 27 Jun 2017 09:31:09 -0400 (EDT) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9F36240D56 for ; Tue, 27 Jun 2017 09:31:09 -0400 (EDT) Received: by mail-lf0-f65.google.com with SMTP id f28so2742931lfi.3 for ; Tue, 27 Jun 2017 06:31:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1498566090.24295.59.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: kvm@vger.kernel.org Cc: marc.zyngier@arm.com, linux-kernel@vger.kernel.org, joe@perches.com, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: kvmarm@lists.cs.columbia.edu On Tue, Jun 27, 2017 at 05:21:30AM -0700, Joe Perches wrote: > On Tue, 2017-06-27 at 15:06 +0300, Roman Storozhenko wrote: > > On Tue, Jun 27, 2017 at 12:01:25PM +0200, Paolo Bonzini wrote: > > > On 27/06/2017 11:54, Roman Storozhenko wrote: > > > > Signed-off-by: Roman Storozhenko > > > > --- > > > > virt/kvm/arm/arm.c | 2 +- > > > > virt/kvm/coalesced_mmio.c | 2 +- > > > > virt/kvm/eventfd.c | 10 ++++++---- > > > > virt/kvm/irqchip.c | 7 ++++--- > > > > virt/kvm/kvm_main.c | 16 ++++++++-------- > > > > 5 files changed, 20 insertions(+), 17 deletions(-) > > > > > > This change is pointless. Contributors to KVM should know what > > > "unsigned" means. > > > > Paolo, thanks that you mentioned this. But I have a question - is this just > > useless or this is an error? > > (Not Paulo and my 2c) Neither really. > > > I saw many places in the codebase where 'unsigned int' is used. That why I > > decided to make the codebase more standartized from the style point of > > view. > > In virt/kvm, there are 16 lines with unsigned, 160 with unsigned int > > , Both statements are correct, yes, it's kinda pointless, > and, yes, it does standardize the declarations. > > It's entirely up the the maintainers (Paulo and Radim) to apply > or reject this style-only trivial patch. The compiler doesn't care. > Joe, thank you for your detailed answer. Anyway I hope that this patch will be accepted despite it is useless from the compiler's point of view. I think that the codebase style matters too.