From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: [PATCH 5/5] KVM: arm/arm64: kvm_arch_vcpu_runnable: don't miss injected irqs Date: Fri, 29 Sep 2017 13:30:41 +0200 Message-ID: <20170929113041.24371-6-drjones@redhat.com> References: <20170929113041.24371-1-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7F0A549C4C for ; Fri, 29 Sep 2017 07:30:42 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ggS6Bm3iVr72 for ; Fri, 29 Sep 2017 07:30:41 -0400 (EDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9492249C55 for ; Fri, 29 Sep 2017 07:30:40 -0400 (EDT) In-Reply-To: <20170929113041.24371-1-drjones@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: kvmarm@lists.cs.columbia.edu Cc: marc.zyngier@arm.com, cdall@linaro.org List-Id: kvmarm@lists.cs.columbia.edu When the vPMU is in use if a VCPU's perf event overflow handler were to fire after the VCPU started waiting, then the wake up done by the kvm_vcpu_kick() call in the handler would do nothing, as no "pmu overflow" state is checked in kvm_arch_vcpu_runnable(). Fix this by checking the IRQ_PENDING VCPU request in runnable(). Checking the request also sufficiently covers all the cases that kvm_vgic_vcpu_pending_irq() cover, so we can just replace that. Signed-off-by: Andrew Jones --- virt/kvm/arm/arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 5bc9b0d2fd0f..725527f491e4 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@ -423,7 +423,7 @@ int kvm_arch_vcpu_runnable(struct kvm_vcpu *vcpu) return !vcpu_should_sleep(vcpu) && (vcpu->arch.mp_state != KVM_MP_STATE_HALTED || (!!vcpu->arch.irq_lines || - kvm_vgic_vcpu_pending_irq(vcpu))); + kvm_test_request(KVM_REQ_IRQ_PENDING, vcpu))); } bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu) -- 2.13.5