From: Marc Zyngier <marc.zyngier@arm.com>
To: Christoffer Dall <cdall@linaro.org>
Cc: kvm@vger.kernel.org,
Kristina Martsenko <kristina.martsenko@arm.com>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] arm: KVM: Fix VTTBR_BADDR_MASK BUG_ON off-by-one
Date: Thu, 16 Nov 2017 17:58:21 +0000 [thread overview]
Message-ID: <20171116175821.26544-8-marc.zyngier@arm.com> (raw)
In-Reply-To: <20171116175821.26544-1-marc.zyngier@arm.com>
VTTBR_BADDR_MASK is used to sanity check the size and alignment of the
VTTBR address. It seems to currently be off by one, thereby only
allowing up to 39-bit addresses (instead of 40-bit) and also
insufficiently checking the alignment. This patch fixes it.
This patch is the 32bit pendent of Kristina's arm64 fix, and
she deserves the actual kudos for pinpointing that one.
Fixes: f7ed45be3ba52 ("KVM: ARM: World-switch implementation")
Cc: <stable@vger.kernel.org> # 3.9
Reported-by: Kristina Martsenko <kristina.martsenko@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
arch/arm/include/asm/kvm_arm.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/include/asm/kvm_arm.h b/arch/arm/include/asm/kvm_arm.h
index c8781450905b..3ab8b3781bfe 100644
--- a/arch/arm/include/asm/kvm_arm.h
+++ b/arch/arm/include/asm/kvm_arm.h
@@ -161,8 +161,7 @@
#else
#define VTTBR_X (5 - KVM_T0SZ)
#endif
-#define VTTBR_BADDR_SHIFT (VTTBR_X - 1)
-#define VTTBR_BADDR_MASK (((_AC(1, ULL) << (40 - VTTBR_X)) - 1) << VTTBR_BADDR_SHIFT)
+#define VTTBR_BADDR_MASK (((_AC(1, ULL) << (40 - VTTBR_X)) - 1) << VTTBR_X)
#define VTTBR_VMID_SHIFT _AC(48, ULL)
#define VTTBR_VMID_MASK(size) (_AT(u64, (1 << size) - 1) << VTTBR_VMID_SHIFT)
--
2.14.2
next prev parent reply other threads:[~2017-11-16 17:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 17:58 [PATCH 0/7] KVM/ARM fixes for 4.15-rc1 Marc Zyngier
2017-11-16 17:58 ` [PATCH 1/7] KVM: arm/arm64: vgic-irqfd: Fix MSI entry allocation Marc Zyngier
2017-11-20 14:49 ` Christoffer Dall
2017-11-16 17:58 ` [PATCH 2/7] KVM: arm/arm64: vgic: Preserve the revious read from the pending table Marc Zyngier
2017-11-20 14:52 ` Christoffer Dall
2017-11-16 17:58 ` [PATCH 3/7] KVM: arm/arm64: vgic-its: " Marc Zyngier
2017-11-20 14:56 ` Christoffer Dall
2017-11-16 17:58 ` [PATCH 4/7] KVM: arm/arm64: vgic-its: Check result of allocation before use Marc Zyngier
2017-11-20 14:58 ` Christoffer Dall
2017-11-21 11:12 ` Marc Zyngier
2017-11-16 17:58 ` [PATCH 5/7] KVM: arm/arm64: vgic-v4: Only perform an unmap for valid vLPIs Marc Zyngier
2017-11-20 15:10 ` Christoffer Dall
2017-11-16 17:58 ` [PATCH 6/7] arm64: KVM: fix VTTBR_BADDR_MASK BUG_ON off-by-one Marc Zyngier
2017-11-16 17:58 ` Marc Zyngier [this message]
2017-11-20 13:29 ` [PATCH 7/7] arm: KVM: Fix " Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116175821.26544-8-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=cdall@linaro.org \
--cc=kristina.martsenko@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=takahiro.akashi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox