From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH] KVM: arm: Use PTR_ERR_OR_ZERO() Date: Fri, 1 Dec 2017 09:00:49 +0100 Message-ID: <20171201080049.GB4218@cbox> References: <1511909297-8585-1-git-send-email-gomonovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 666E149D5E for ; Fri, 1 Dec 2017 02:57:51 -0500 (EST) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XS6yPE1CxG2f for ; Fri, 1 Dec 2017 02:57:50 -0500 (EST) Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 2EC2740D25 for ; Fri, 1 Dec 2017 02:57:50 -0500 (EST) Received: by mail-wr0-f193.google.com with SMTP id s66so9082076wrc.9 for ; Fri, 01 Dec 2017 00:00:49 -0800 (PST) Content-Disposition: inline In-Reply-To: <1511909297-8585-1-git-send-email-gomonovych@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Vasyl Gomonovych Cc: marc.zyngier@arm.com, andre.przywara@arm.com, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: kvmarm@lists.cs.columbia.edu Hi Vasyl, On Tue, Nov 28, 2017 at 11:48:17PM +0100, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > virt/kvm/arm/vgic/vgic-its.c:971:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci For new code, sure it would make sense to use this. But why is it worth changing existing code to use PTR_ERR_OR_ZERO? Thanks, -Christoffer > > Signed-off-by: Vasyl Gomonovych > --- > virt/kvm/arm/vgic/vgic-its.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c > index 1f761a9991e7..28d85754320b 100644 > --- a/virt/kvm/arm/vgic/vgic-its.c > +++ b/virt/kvm/arm/vgic/vgic-its.c > @@ -1032,10 +1032,8 @@ static int vgic_its_cmd_handle_mapd(struct kvm *kvm, struct vgic_its *its, > > device = vgic_its_alloc_device(its, device_id, itt_addr, > num_eventid_bits); > - if (IS_ERR(device)) > - return PTR_ERR(device); > > - return 0; > + return PTR_ERR_OR_ZERO(device); > } > > /* > -- > 1.9.1 >