From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v7 05/25] ACPI / APEI: Make estatus pool allocation a static size Date: Tue, 11 Dec 2018 17:54:14 +0100 Message-ID: <20181211165414.GJ27375@zn.tnic> References: <20181203180613.228133-1-james.morse@arm.com> <20181203180613.228133-6-james.morse@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 600A04A2E9 for ; Tue, 11 Dec 2018 11:54:19 -0500 (EST) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RtBxUMKxEjsf for ; Tue, 11 Dec 2018 11:54:18 -0500 (EST) Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 85CE84A1DD for ; Tue, 11 Dec 2018 11:54:18 -0500 (EST) Content-Disposition: inline In-Reply-To: <20181203180613.228133-6-james.morse@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: James Morse Cc: Rafael Wysocki , Tony Luck , Fan Wu , linux-mm@kvack.org, Marc Zyngier , Catalin Marinas , Will Deacon , Dongjiu Geng , linux-acpi@vger.kernel.org, Naoya Horiguchi , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Len Brown List-Id: kvmarm@lists.cs.columbia.edu On Mon, Dec 03, 2018 at 06:05:53PM +0000, James Morse wrote: > Adding new NMI-like notifications duplicates the calls that grow > and shrink the estatus pool. This is all pretty pointless, as the > size is capped to 64K. Allocate this for each ghes and drop > the code that grows and shrinks the pool. > > Suggested-by: Borislav Petkov > Signed-off-by: James Morse > --- > drivers/acpi/apei/ghes.c | 49 +++++----------------------------------- > drivers/acpi/apei/hest.c | 2 +- > include/acpi/ghes.h | 2 +- > 3 files changed, 8 insertions(+), 45 deletions(-) Nice and simple, cool. Thanks for doing that. Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.