From: Dave Martin <Dave.Martin@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Okamoto Takayuki <tokamoto@jp.fujitsu.com>,
Christoffer Dall <cdall@kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Zhang Lei <zhang.lei@jp.fujitsu.com>,
Julien Grall <julien.grall@arm.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 00/27] KVM: arm64: SVE guest support
Date: Fri, 29 Mar 2019 15:06:44 +0000 [thread overview]
Message-ID: <20190329150642.GD3567@e103592.cambridge.arm.com> (raw)
In-Reply-To: <bed45c04-9b67-9e30-d73e-adc07a902de1@arm.com>
On Fri, Mar 29, 2019 at 02:56:36PM +0000, Marc Zyngier wrote:
> Hi Dave,
>
> On 29/03/2019 13:00, Dave Martin wrote:
> > This series implements support for allowing KVM guests to use the Arm
> > Scalable Vector Extension (SVE), superseding the previous v6 series [1].
> >
> > The patches are also available on a branch for reviewer convenience. [2]
> >
> > The patches are based on v5.1-rc2.
> >
> > This series addresses a couple of minor review comments received on v6
> > and otherwise applies reviewer tags only. The code differences
> > between v6 and this series consist of minor cosmetic fixups only.
> >
> > Draft kvmtool patches were posted separately [3], [4].
> >
> > For a description of minor updates, see the individual patches.
> >
> >
> > Thanks go to Julien Thierry and Julian Grall for their review efforts,
> > and to Zhang Lei for testing the series -- many thanks for their help
> > in getting the series to this point!
> >
> >
> > Reviewers' attention is drawn to the following patches, which have no
> > Reviewed-by/Acked-by. Please take a look if you have a moment.
> >
> > * Patch 11 (KVM: arm64: Support runtime sysreg visibility filtering)
> >
> > Previously Reviewed-by Julien Thierry, but this version of the
> > patch contains some minor rework suggested by Mark Rutland during
> > the v5 review [5].
> >
> > * Patch 15 (KVM: arm64: Add missing #include of <linux/string.h>
> > in guest.c)
> >
> > (Trivial patch.)
> >
> > * Patch 26: (KVM: Document errors for KVM_GET_ONE_REG and
> > KVM_SET_ONE_REG)
> >
> > (Documentation only.)
> >
> > * Patch 27: KVM: arm64/sve: Document KVM API extensions for SVE
> >
> > (Documentation only.)
>
> In order to get people to test this a bit more, I've now pushed this
> series into -next. I'm pretty confident that it won't break a thing, but
> better safe than sorry. I also expect any fix to be pushed on top of
> this series.
>
> This doesn't mean that the review is over, quite the opposite. I intend
> to go over it once more, and I'd like other people to do the same
> (specially anyone looking at implementing the required support in QEMU).
Agreed, thanks for pushing it to next.
I'll continue testing and await further review from people.
Cheers
---Dave
next prev parent reply other threads:[~2019-03-29 15:06 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 13:00 [PATCH v7 00/27] KVM: arm64: SVE guest support Dave Martin
2019-03-29 13:00 ` [PATCH v7 01/27] KVM: Documentation: Document arm64 core registers in detail Dave Martin
2019-04-24 9:25 ` Alex Bennée
2019-03-29 13:00 ` [PATCH v7 02/27] arm64: fpsimd: Always set TIF_FOREIGN_FPSTATE on task state flush Dave Martin
2019-03-29 13:00 ` [PATCH v7 03/27] KVM: arm64: Delete orphaned declaration for __fpsimd_enabled() Dave Martin
2019-03-29 13:00 ` [PATCH v7 04/27] KVM: arm64: Refactor kvm_arm_num_regs() for easier maintenance Dave Martin
2019-03-29 13:00 ` [PATCH v7 05/27] KVM: arm64: Add missing #includes to kvm_host.h Dave Martin
2019-03-29 13:00 ` [PATCH v7 06/27] arm64/sve: Clarify role of the VQ map maintenance functions Dave Martin
2019-04-04 21:21 ` Andrew Jones
2019-03-29 13:00 ` [PATCH v7 07/27] arm64/sve: Check SVE virtualisability Dave Martin
2019-04-04 21:21 ` Andrew Jones
2019-04-05 9:35 ` Dave Martin
2019-03-29 13:00 ` [PATCH v7 08/27] arm64/sve: Enable SVE state tracking for non-task contexts Dave Martin
2019-03-29 13:00 ` [PATCH v7 09/27] KVM: arm64: Add a vcpu flag to control SVE visibility for the guest Dave Martin
2019-04-03 19:14 ` Andrew Jones
2019-04-04 3:17 ` Marc Zyngier
2019-04-04 7:53 ` Dave Martin
2019-04-04 21:15 ` Andrew Jones
2019-03-29 13:00 ` [PATCH v7 10/27] KVM: arm64: Propagate vcpu into read_id_reg() Dave Martin
2019-04-04 21:15 ` Andrew Jones
2019-03-29 13:00 ` [PATCH v7 11/27] KVM: arm64: Support runtime sysreg visibility filtering Dave Martin
2019-04-03 19:17 ` Andrew Jones
2019-04-24 9:39 ` Alex Bennée
2019-04-24 13:47 ` Dave Martin
2019-04-24 13:47 ` Dave Martin
2019-03-29 13:00 ` [PATCH v7 12/27] KVM: arm64/sve: System register context switch and access support Dave Martin
2019-04-03 19:39 ` Andrew Jones
2019-04-04 8:06 ` Dave Martin
2019-04-04 8:32 ` Andrew Jones
2019-04-04 8:47 ` Dave Martin
2019-04-04 8:59 ` Andrew Jones
2019-04-24 15:21 ` Alex Bennée
2019-04-25 13:28 ` Dave Martin
2019-04-25 13:28 ` Dave Martin
2019-03-29 13:00 ` [PATCH v7 13/27] KVM: arm64/sve: Context switch the SVE registers Dave Martin
2019-04-03 20:01 ` Andrew Jones
2019-04-04 8:10 ` Dave Martin
2019-04-04 8:35 ` Andrew Jones
2019-04-04 8:36 ` Dave Martin
2019-04-24 14:51 ` Alex Bennée
2019-04-25 13:35 ` Dave Martin
2019-04-25 13:35 ` Dave Martin
2019-03-29 13:00 ` [PATCH v7 14/27] KVM: Allow 2048-bit register access via ioctl interface Dave Martin
2019-04-04 21:11 ` Andrew Jones
2019-03-29 13:00 ` [PATCH v7 15/27] KVM: arm64: Add missing #include of <linux/string.h> in guest.c Dave Martin
2019-03-29 13:00 ` [PATCH v7 16/27] KVM: arm64: Factor out core register ID enumeration Dave Martin
2019-04-02 2:41 ` Marc Zyngier
2019-04-02 8:59 ` Dave Martin
2019-04-02 9:32 ` Marc Zyngier
2019-04-02 9:54 ` Dave P Martin
2019-03-29 13:00 ` [PATCH v7 17/27] KVM: arm64: Reject ioctl access to FPSIMD V-regs on SVE vcpus Dave Martin
2019-04-03 20:15 ` Andrew Jones
2019-04-24 13:45 ` Alex Bennée
2019-03-29 13:00 ` [PATCH v7 18/27] KVM: arm64/sve: Add SVE support to register access ioctl interface Dave Martin
2019-04-04 13:57 ` Andrew Jones
2019-04-04 14:50 ` Dave Martin
2019-04-04 16:25 ` Andrew Jones
2019-04-04 16:56 ` Dave Martin
2019-03-29 13:00 ` [PATCH v7 19/27] KVM: arm64: Enumerate SVE register indices for KVM_GET_REG_LIST Dave Martin
2019-04-04 14:08 ` Andrew Jones
2019-04-05 9:35 ` Dave Martin
2019-04-05 9:45 ` Andrew Jones
2019-04-05 11:11 ` Dave Martin
2019-03-29 13:00 ` [PATCH v7 20/27] arm64/sve: In-kernel vector length availability query interface Dave Martin
2019-04-04 14:20 ` Andrew Jones
2019-04-05 9:35 ` Dave Martin
2019-04-05 9:54 ` Andrew Jones
2019-04-05 11:13 ` Dave Martin
2019-03-29 13:00 ` [PATCH v7 21/27] KVM: arm/arm64: Add hook for arch-specific KVM initialisation Dave Martin
2019-04-04 14:25 ` Andrew Jones
2019-04-04 14:53 ` Dave Martin
2019-04-04 16:33 ` Andrew Jones
2019-04-05 9:36 ` Dave Martin
2019-04-05 10:40 ` Andrew Jones
2019-04-05 11:14 ` Dave Martin
2019-03-29 13:00 ` [PATCH v7 22/27] KVM: arm/arm64: Add KVM_ARM_VCPU_FINALIZE ioctl Dave Martin
2019-04-04 15:07 ` Andrew Jones
2019-04-04 16:47 ` Dave Martin
2019-03-29 13:00 ` [PATCH v7 23/27] KVM: arm64/sve: Add pseudo-register for the guest's vector lengths Dave Martin
2019-04-04 20:18 ` Andrew Jones
2019-04-05 9:36 ` Dave Martin
2019-04-05 10:14 ` Andrew Jones
2019-04-05 12:54 ` Dave Martin
2019-04-05 15:33 ` Andrew Jones
2019-04-10 12:42 ` Dave Martin
2019-04-10 12:42 ` Dave Martin
2019-04-04 20:31 ` Andrew Jones
2019-04-05 9:36 ` Dave Martin
2019-04-05 10:22 ` Andrew Jones
2019-04-05 14:06 ` Dave Martin
2019-04-05 15:41 ` Andrew Jones
2019-04-10 12:35 ` Dave Martin
2019-04-10 12:35 ` Dave Martin
2019-03-29 13:00 ` [PATCH v7 24/27] KVM: arm64/sve: Allow userspace to enable SVE for vcpus Dave Martin
2019-04-04 20:36 ` Andrew Jones
2019-03-29 13:00 ` [PATCH v7 25/27] KVM: arm64: Add a capability to advertise SVE support Dave Martin
2019-04-04 20:39 ` Andrew Jones
2019-03-29 13:00 ` [PATCH v7 26/27] KVM: Document errors for KVM_GET_ONE_REG and KVM_SET_ONE_REG Dave Martin
2019-04-03 20:27 ` Andrew Jones
2019-04-04 8:35 ` Dave Martin
2019-04-04 9:34 ` Andrew Jones
2019-04-04 9:38 ` Dave P Martin
2019-04-04 9:45 ` Andrew Jones
2019-03-29 13:00 ` [PATCH v7 27/27] KVM: arm64/sve: Document KVM API extensions for SVE Dave Martin
2019-04-04 21:09 ` Andrew Jones
2019-04-05 9:36 ` Dave Martin
2019-04-05 10:39 ` Andrew Jones
2019-04-05 13:00 ` Dave Martin
2019-04-05 15:38 ` Andrew Jones
2019-04-10 12:34 ` Dave Martin
2019-04-10 12:34 ` Dave Martin
2019-03-29 14:56 ` [PATCH v7 00/27] KVM: arm64: SVE guest support Marc Zyngier
2019-03-29 15:06 ` Dave Martin [this message]
2019-04-05 16:41 ` Dave Martin
2019-04-25 10:33 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329150642.GD3567@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=cdall@kernel.org \
--cc=julien.grall@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=tokamoto@jp.fujitsu.com \
--cc=will.deacon@arm.com \
--cc=zhang.lei@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox