Re: [PATCH kvmtool v3 1/9] update_headers.sh: Add missing shell quoting

Dave Martin
2019-06-03T10:40:36Z

On Fri, May 31, 2019 at 06:02:53PM +0100, Andre Przywara wrote:
> On Thu, 30 May 2019 16:13:06 +0100
> Dave Martin <Dave.Martin@arm.com> wrote:
>
> > update_headers.sh can break if the current working directory has a
> > funny name or if something odd is passed for LINUX_ROOT.
>
> Do you actually have spaces in your Linux path? ;-)

No. I'm assuming that people using a fancy desktop need to call it
"My Linux Kernel" in order to comprehend what it is though.

(Only joking!)

> > In the interest of cleanliness, quote where appropriate.
> >
> > Signed-off-by: Dave Martin <Dave.Martin@arm.com>
>
> Looks alright to me:
>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>

[...]

Thanks
---Dave