Re: [PATCH kvmtool v3 6/9] arm/arm64: Factor out ptrauth vcpu feature setup

Dave Martin
2019-06-03T11:12:32Z

On Fri, May 31, 2019 at 06:04:36PM +0100, Andre Przywara wrote:
> On Thu, 30 May 2019 16:13:11 +0100
> Dave Martin <Dave.Martin@arm.com> wrote:
>
> > In the interest of readability, factor out the vcpu feature setup
> > for ptrauth into a separate function.
> >
> > Also, because aarch32 doesn't have this feature or the related
> > command line options anyway, move the actual code into aarch64/.
> >
> > Since ARM_VCPU_PTRAUTH_FEATURE is only there to make the ptrauth
> > feature setup code compile on arm, it is no longer needed: inline
> > and remove it.
>
> I am not sure this is useful as a separate patch, so can we just merge
> this into 5/9?

Could be. I wanted to keep the changes against Amit's original patch
clear for now, so it's easier for him to review.

Cheers
---Dave