Re: [PATCH kvmtool v3 2/9] update_headers.sh: Cleanly report failure on error

Dave Martin
2019-06-03T10:41:58Z

On Fri, May 31, 2019 at 06:03:10PM +0100, Andre Przywara wrote:
> On Thu, 30 May 2019 16:13:07 +0100
> Dave Martin <Dave.Martin@arm.com> wrote:
>
> > If in intermediate step fails, update_headers.sh blindly continues
> > and may return success status.
> >
> > To avoid errors going unnoticed when driving this script, exit and
> > report failure status as soon as something goes wrong. For good
> > measure, also fail on expansion of undefined shell variables to aid
> > future maintainers.
> >
> > Signed-off-by: Dave Martin <Dave.Martin@arm.com>
>
> Both "u" and "e" seem to be standard and work in dash and ash, so:
>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Thanks.

Those options have been there forever, so I presume they are specified
by POSIX... but I confess I didn't check.

Cheers
---Dave