Re: [PATCH kvmtool v3 2/9] update_headers.sh: Cleanly report failure on error

Andre Przywara
2019-05-31T17:03:20Z

On Thu, 30 May 2019 16:13:07 +0100
Dave Martin <Dave.Martin@arm.com> wrote:

> If in intermediate step fails, update_headers.sh blindly continues
> and may return success status.
>
> To avoid errors going unnoticed when driving this script, exit and
> report failure status as soon as something goes wrong. For good
> measure, also fail on expansion of undefined shell variables to aid
> future maintainers.
>
> Signed-off-by: Dave Martin <Dave.Martin@arm.com>

Both "u" and "e" seem to be standard and work in dash and ash, so:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Thanks,
Andre.

> ---
> util/update_headers.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/util/update_headers.sh b/util/update_headers.sh
> index 4ba1b9f..a7e21b8 100755
> --- a/util/update_headers.sh
> +++ b/util/update_headers.sh
> @@ -7,6 +7,8 @@
> # using the lib/modules/`uname -r`/source link.
> ########################################################################
>
> +set -ue
> +
> if [ "$#" -ge 1 ]
> then
> LINUX_ROOT="$1"