Re: [PATCH 03/15] arm64: kvm: Fix symbol dependency in __hyp_call_panic_nvhe

Marc Zyngier
2020-05-10T11:14:37Z

Hi David,

On Thu, 07 May 2020 15:36:17 +0100,
David Brazdil <dbrazdil@google.com> wrote:
>
> Hi Marc,
>
> >
> > What breaks without this constraint? Is it a fix that should go in
> > early? Otherwise looks good.
>
> This only becomes an issue when __hyp_call_panic_nvhe() and
> __hyp_call_panic_vhe() are moved to separate files, so I don't think
> it's necessary to go in early.
>
> Currently the string variable (declared static) is seen by the C
> compiler as used by __hyp_call_panic_vhe(). But when split, the
> variable in the nVHE source file becomes unused, is dropped by the
> compiler and the inline assembly's reference is unresolved. We could
> then alias __hyp_text___hyp_panic_string back to the VHE copy, but
> this is the right way of addressing it.

Thanks for the detailed explanation. I think some of it should make it
in the commit message, pointing what breaks and when.

M.

--
Without deviation from the norm, progress is not possible.