From: Andrew Scull <ascull@google.com>
To: Gavin Shan <gshan@redhat.com>
Cc: catalin.marinas@arm.com, will@kernel.org,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] kvm/arm64: Rename HSR to ESR
Date: Mon, 29 Jun 2020 10:44:44 +0100 [thread overview]
Message-ID: <20200629094444.GA3282863@google.com> (raw)
In-Reply-To: <20200629091841.88198-2-gshan@redhat.com>
On Mon, Jun 29, 2020 at 07:18:40PM +1000, Gavin Shan wrote:
> kvm/arm32 isn't supported since commit 541ad0150ca4 ("arm: Remove
> 32bit KVM host support"). So HSR isn't meaningful since then. This
> renames HSR to ESR accordingly. This shouldn't cause any functional
> changes:
>
> * Rename kvm_vcpu_get_hsr() to kvm_vcpu_get_esr() to make the
> function names self-explanatory.
> * Rename variables from @hsr to @esr to make them self-explanatory.
I like this; there's been more than once this has confused me recently!
Acked-by: Andrew Scull <ascull@google.com>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-06-29 9:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 9:18 [PATCH 0/2] Refactor ESR related functions Gavin Shan
2020-06-29 9:18 ` [PATCH 1/2] kvm/arm64: Rename HSR to ESR Gavin Shan
2020-06-29 9:44 ` Andrew Scull [this message]
2020-06-29 10:32 ` Mark Rutland
2020-06-29 11:05 ` Mark Rutland
2020-06-29 17:00 ` Marc Zyngier
2020-06-29 23:14 ` Gavin Shan
2020-06-29 9:18 ` [PATCH 2/2] kvm/arm64: Detach ESR operator from vCPU struct Gavin Shan
2020-06-29 9:59 ` Andrew Scull
2020-06-30 0:28 ` Gavin Shan
2020-06-29 11:00 ` Mark Rutland
2020-06-30 0:16 ` Gavin Shan
2020-06-30 8:00 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629094444.GA3282863@google.com \
--to=ascull@google.com \
--cc=catalin.marinas@arm.com \
--cc=gshan@redhat.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox