From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB8BC2D0E4 for ; Thu, 19 Nov 2020 11:15:02 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 0616E2083B for ; Thu, 19 Nov 2020 11:15:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="uyZKU41r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0616E2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 25F1D4B48F; Thu, 19 Nov 2020 06:15:01 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lYx1sw5EsIM6; Thu, 19 Nov 2020 06:15:00 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 33EF04B330; Thu, 19 Nov 2020 06:15:00 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2D5224B32C for ; Thu, 19 Nov 2020 06:14:59 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VAMApbX2OMQV for ; Thu, 19 Nov 2020 06:14:57 -0500 (EST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D04214B32F for ; Thu, 19 Nov 2020 06:14:57 -0500 (EST) Received: by mail-wm1-f68.google.com with SMTP id w24so6390930wmi.0 for ; Thu, 19 Nov 2020 03:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AT6vz2m42JXc7lrJwjmpvEMB8s7HSthxy8G6z45TFw8=; b=uyZKU41rSPFAFtLcohcLT9M2PYocUNVHWJWTf53IFCaNw7mcYBQ/OV5mF+Z9pUbtfJ pdGu30hiumiwL19aJe2aDPkmVcdpTz5KoWexqw70c9y9oBC49pNNsde7osvyz+XO6v51 rxLO0OtV9yAmrJsEQRwQduDZyGZzh0/tJXDAFuP3Dkx3uNnotD3KgqM5ZYL58mtpgG8g 41MOobefny3kFsPuCQY7AYFsMiN7wk2fscZESRIZd6slXTGiOo3U6S/OMJU8YKhwc1eO +mcuricEPz+YrRLiUnP9AvGQ/imaM0YwAZgi92o8A7PM6dcH1Gq5syyb3fl9WETdoAlZ Scaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AT6vz2m42JXc7lrJwjmpvEMB8s7HSthxy8G6z45TFw8=; b=giEvwzLVFFWRRB+om444LvjCFrsg9QGe5IbhTarIDwthlZcPjzxJ0agVcS1sugNdeQ zUal8QfJIHYr1xZ8CxjyF8bAMGkw71S7Q19qcCeuwqV9zijuMC8lXYuzQp0Y3Oyc76bi AGGlsZZ5f+1zrovIMvn/8a082de/New3+SeuMyhptFdCgWfr0obpRO7l0OmMhZICWygW zLaveDNhAoxSZw47dXjqY8IGIbdTH4A+ziCYXO9XVVhOpvbFpp/95kvDNxCCcbu6pLAF VkagDKcyVpd5UXKyvKH8fXj+s8g063kaLl9JPWbA9V9+Y4LFnMzwyJRSwGQWMeEJuLUS sUeA== X-Gm-Message-State: AOAM530gKi6tnYxWTXkmWGSPH06qlw9KAk5tDCUbSKF94HxTLqtOwq/F Jn2lf3MCpIoH1W8Xi+dxeTIhtQ== X-Google-Smtp-Source: ABdhPJyhjWDduxIBws3Ul6EHk3OG2nFzeTTtIhTcNveUaPVZ7P2RuGx59RiEB/hStDd4b5hulEmX3w== X-Received: by 2002:a1c:7704:: with SMTP id t4mr4065727wmi.48.1605784496615; Thu, 19 Nov 2020 03:14:56 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:9843:cd3f:f36b:d55c]) by smtp.gmail.com with ESMTPSA id b124sm9245409wmh.13.2020.11.19.03.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 03:14:55 -0800 (PST) Date: Thu, 19 Nov 2020 11:14:54 +0000 From: David Brazdil To: Marc Zyngier Subject: Re: [PATCH v2 3/5] KVM: arm64: Patch kimage_voffset instead of loading the EL1 value Message-ID: <20201119111454.vrbogriragp7zukk@google.com> References: <20201109175923.445945-1-maz@kernel.org> <20201109175923.445945-4-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201109175923.445945-4-maz@kernel.org> Cc: kernel-team@android.com, kvm@vger.kernel.org, Will Deacon , ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hey Marc, Just noticed in kvmarm/queue that the whitespacing in this patch is off. > +.macro kimg_pa reg, tmp > +alternative_cb kvm_get_kimage_voffset > + movz \tmp, #0 > + movk \tmp, #0, lsl #16 > + movk \tmp, #0, lsl #32 > + movk \tmp, #0, lsl #48 > +alternative_cb_end > + > + /* reg = __pa(reg) */ > + sub \reg, \reg, \tmp > +.endm This uses spaces instead of tabs. > + > #else This added empty line actually has a tab in it. -David _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm