From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF2CC48BDF for ; Fri, 18 Jun 2021 14:52:53 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id A0EBB61260 for ; Fri, 18 Jun 2021 14:52:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0EBB61260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 429A14A418; Fri, 18 Jun 2021 10:52:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8zdkz1umWFTe; Fri, 18 Jun 2021 10:52:50 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 660C14A4E5; Fri, 18 Jun 2021 10:52:50 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4094D4A3A3 for ; Fri, 18 Jun 2021 10:52:49 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ae55TfVipxZW for ; Fri, 18 Jun 2021 10:52:48 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4804D49F82 for ; Fri, 18 Jun 2021 10:52:48 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 90485610A3; Fri, 18 Jun 2021 14:52:44 +0000 (UTC) Date: Fri, 18 Jun 2021 15:52:42 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl Message-ID: <20210618145241.GG16116@arm.com> References: <20210618132826.54670-1-steven.price@arm.com> <20210618132826.54670-8-steven.price@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210618132826.54670-8-steven.price@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > +When this capability is enabled all memory in (non-device) memslots must not > +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result > +in an -EINVAL return. "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as that's a kernel internal and not something the VMM needs to be aware of. Just say something like "memslots must be mapped as shareable (MAP_SHARED)". Otherwise: Reviewed-by: Catalin Marinas _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm