From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11DDBC4338F for ; Fri, 30 Jul 2021 13:11:16 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 83D5960F46 for ; Fri, 30 Jul 2021 13:11:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 83D5960F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1CC8D4A2E5; Fri, 30 Jul 2021 09:11:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9Fez2rIyaAFy; Fri, 30 Jul 2021 09:11:12 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8DEF54B090; Fri, 30 Jul 2021 09:11:12 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C382C4A483 for ; Fri, 30 Jul 2021 09:11:11 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QbNuBH0MpldY for ; Fri, 30 Jul 2021 09:11:10 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id CD8B94A2E5 for ; Fri, 30 Jul 2021 09:11:09 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id AFDF760462; Fri, 30 Jul 2021 13:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627650668; bh=dCPVqim+3QLsfYnttxB0ASgmRObsONjZkZ9VkM4UMZA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YRmmKBxntTjK6srQwnni3UZ1ku7RqG9OCZSgjIgPkKxdxzbKcEHnjt5qO++TlplUW bHNVzY6wzSMTntl5eF+8RU7L32sdKysWQfa+UCGrzlf0PKDKmsfHrdn26DiQVyJmfP +GyoQSuIuIgCuG+zUi5lJb97/6wYrh94i/+Vy2SR8ZMsnzvXGWZJOh14jQYNgMzGnR X0+oF97+vle8eTXlYuW4uw7VFzE21pHS8AcU+FtEqoD/ivoz5m4T1riIgHaUr+v5eF FbxXGurZZJEGmNg3ZXivybbt+XAoKlM1hKHXIhfCqbYoQSmrPqPtN4n+/L0rKzCKE8 fFT+yqgfRfiyQ== Date: Fri, 30 Jul 2021 14:11:03 +0100 From: Will Deacon To: Marc Zyngier Subject: Re: [PATCH 07/16] KVM: arm64: Wire MMIO guard hypercalls Message-ID: <20210730131103.GD23756@willie-the-truck> References: <20210715163159.1480168-1-maz@kernel.org> <20210715163159.1480168-8-maz@kernel.org> <20210727181145.GF19173@willie-the-truck> <87v94ud8av.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87v94ud8av.wl-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kvm@vger.kernel.org, kernel-team@android.com, Srivatsa Vaddagiri , linux-kernel@vger.kernel.org, Shanker R Donthineni , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Jul 28, 2021 at 11:47:20AM +0100, Marc Zyngier wrote: > On Tue, 27 Jul 2021 19:11:46 +0100, > Will Deacon wrote: > > > > On Thu, Jul 15, 2021 at 05:31:50PM +0100, Marc Zyngier wrote: > > > Plumb in the hypercall interface to allow a guest to discover, > > > enroll, map and unmap MMIO regions. > > > > > > Signed-off-by: Marc Zyngier > > > --- > > > arch/arm64/kvm/hypercalls.c | 20 ++++++++++++++++++++ > > > include/linux/arm-smccc.h | 28 ++++++++++++++++++++++++++++ > > > 2 files changed, 48 insertions(+) > > > > > > diff --git a/arch/arm64/kvm/hypercalls.c b/arch/arm64/kvm/hypercalls.c > > > index 30da78f72b3b..a3deeb907fdd 100644 > > > --- a/arch/arm64/kvm/hypercalls.c > > > +++ b/arch/arm64/kvm/hypercalls.c > > > @@ -5,6 +5,7 @@ > > > #include > > > > > > #include > > > +#include > > > > > > #include > > > #include > > > @@ -129,10 +130,29 @@ int kvm_hvc_call_handler(struct kvm_vcpu *vcpu) > > > case ARM_SMCCC_VENDOR_HYP_KVM_FEATURES_FUNC_ID: > > > val[0] = BIT(ARM_SMCCC_KVM_FUNC_FEATURES); > > > val[0] |= BIT(ARM_SMCCC_KVM_FUNC_PTP); > > > + val[0] |= BIT(ARM_SMCCC_KVM_FUNC_MMIO_GUARD_INFO); > > > + val[0] |= BIT(ARM_SMCCC_KVM_FUNC_MMIO_GUARD_ENROLL); > > > + val[0] |= BIT(ARM_SMCCC_KVM_FUNC_MMIO_GUARD_MAP); > > > + val[0] |= BIT(ARM_SMCCC_KVM_FUNC_MMIO_GUARD_UNMAP); > > > break; > > > case ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID: > > > kvm_ptp_get_time(vcpu, val); > > > break; > > > + case ARM_SMCCC_VENDOR_HYP_KVM_MMIO_GUARD_INFO_FUNC_ID: > > > + val[0] = PAGE_SIZE; > > > + break; > > > > I get the nagging feeling that querying the stage-2 page-size outside of > > MMIO guard is going to be useful once we start looking at memory sharing, > > so perhaps rename this to something more generic? > > At this stage, why not follow the architecture and simply expose it as > ID_AA64MMFR0_EL1.TGran{4,64,16}_2? That's exactly what it is for, and > we already check for this in KVM itself. Nice, I hadn't thought of that. On reflection, though, I don't agree that it's "exactly what it is for" -- the ID register talks about the supported stage-2 page-sizes, whereas we want to advertise the one page size that we're currently using. In other words, it's important that we only ever populate one of the fields and I wonder if that could bite us in future somehow? Up to you, you've definitely got a better feel for this than me. > > > + case ARM_SMCCC_VENDOR_HYP_KVM_MMIO_GUARD_ENROLL_FUNC_ID: > > > + set_bit(KVM_ARCH_FLAG_MMIO_GUARD, &vcpu->kvm->arch.flags); > > > + val[0] = SMCCC_RET_SUCCESS; > > > + break; > > > + case ARM_SMCCC_VENDOR_HYP_KVM_MMIO_GUARD_MAP_FUNC_ID: > > > + if (kvm_install_ioguard_page(vcpu, vcpu_get_reg(vcpu, 1))) > > > + val[0] = SMCCC_RET_SUCCESS; > > > + break; > > > + case ARM_SMCCC_VENDOR_HYP_KVM_MMIO_GUARD_UNMAP_FUNC_ID: > > > + if (kvm_remove_ioguard_page(vcpu, vcpu_get_reg(vcpu, 1))) > > > + val[0] = SMCCC_RET_SUCCESS; > > > + break; > > > > I think there's a slight discrepancy between MAP and UNMAP here in that > > calling UNMAP on something that hasn't been mapped will fail, whereas > > calling MAP on something that's already been mapped will succeed. I think > > that might mean you can't reason about the final state of the page if two > > vCPUs race to call these functions in some cases (and both succeed). > > I'm not sure that's the expected behaviour for ioremap(), for example > (you can ioremap two portions of the same page successfully). Hmm, good point. Does that mean we should be refcounting the stage-2? Otherwise if we do something like: foo = ioremap(page, 0x100); bar = ioremap(page+0x100, 0x100); iounmap(foo); then bar will break. Or did I miss something in the series? Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm