Re: [PATCH v2 10/14] arm64/nmi: Manage masking for superpriority interrupts along with DAIF

Mark Brown
2022-12-15T13:21:23Z

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

On Mon, Dec 12, 2022 at 02:40:08PM +0000, Mark Rutland wrote:

> Please, no. NAK to pretending this is part of DAIF.

> The existing hacks to bodge pseudo-NMI into the DAIF management code are
> convoluted, difficult to maintain, and they have known cases where they
> *cannot* do the right thing. Those existing hacks have proved to be more
> trouble than they're worth, and continuing down that path makes things worse.

As discussed elsehwere I do agree that the current "DAIF is an
abstraction" approach isn't great and cleanup is needed but have a hard
time seeing these changes as making things appreciably worse than they
already are with pseudo NMI. In any case there was some demand for the
patches to be out there, and for collaboration on the GIC parts so I'll
keep posting the patches in parallel with the refactoring.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]