Re: [PATCH v2 03/14] arm64/sysreg: Add definition of ISR_EL1

Marc Zyngier
2022-12-05T16:45:13Z

On Sat, 12 Nov 2022 15:16:57 +0000,
Mark Brown <broonie@kernel.org> wrote:
>
> Add a definition of ISR_EL1 as per DDI0487I.a. This register was not
> previously defined in sysreg.h, no functional changes.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm64/tools/sysreg | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 5d0d2498c635..3660e680b7f5 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1079,6 +1079,16 @@ Res0 15:8
> Field 7:0 LR
> EndSysreg
>
> +Sysreg ISR_EL1 3 0 12 1 0
> +Res0 63:11
> +Field 10 IS
> +Field 9 FS
> +Field 8 A

You might as well make use of this field in arch/arm64/kvm/hyp/entry.S

> +Field 7 I
> +Field 6 F
> +Res0 5:0
> +EndSysreg
> +
> Sysreg ICC_NMIAR1_EL1 3 0 12 9 5
> Res0 63:24
> Field 23:0 INTID

Thanks,

M.

--
Without deviation from the norm, progress is not possible.