Re: [PATCH v1 1/3] arm64/sysreg: Add definition for ICC_NMIAR1_EL1

Marc Zyngier
2022-12-07T18:35:09Z

On Wed, 07 Dec 2022 18:16:10 +0000,
Mark Brown <broonie@kernel.org> wrote:
>
> [1 <text/plain; us-ascii (7bit)>]
> On Wed, Dec 07, 2022 at 03:08:48PM +0000, Marc Zyngier wrote:
> > Mark Brown <broonie@kernel.org> wrote:
>
> > > Given the textual conflict with the ISR patch and the fact that the NMI
> > > series needs both anyway it seemed more productive to just carry them
> > > both in the cleanup series even if this one isn't immediately used.
>
> > I thought the point of this series was to extract stuff that was
> > otherwise useful, independently of the NMI series.
>
> I tend to view the system register definitions as just generally useful,
> this being system register definitions plus a cleanup that could be done
> on top.

I tend to view the *unused* system register definition as pointless
churn. We'll have to agree to disagree on that one.

>
> > I must have misunderstood its purpose. This is instead making things
> > harder to follow. Oh well.
>
> I am hopeful that the extra cognative load of an additional register
> definition will be managable.

You never know.

M.

--
Without deviation from the norm, progress is not possible.