Re: [PATCH v1 3/3] KVM: arm64: Use symbolic definition for ISR_EL1.A

Marc Zyngier
2022-12-07T11:18:12Z

On Tue, 06 Dec 2022 13:11:44 +0000,
Mark Brown <broonie@kernel.org> wrote:
>
> Now that we are generating ISR_EL1 we have acquired a constant for
> ISR_EL1.A, use it rather than the magic number we had been using in the KVM
> entry code.
>
> Suggested-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm64/kvm/hyp/entry.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/hyp/entry.S b/arch/arm64/kvm/hyp/entry.S
> index 435346ea1504..f3aa7738b477 100644
> --- a/arch/arm64/kvm/hyp/entry.S
> +++ b/arch/arm64/kvm/hyp/entry.S
> @@ -171,7 +171,7 @@ alternative_else
> dsb sy // Synchronize against in-flight ld/st
> isb // Prevent an early read of side-effect free ISR
> mrs x2, isr_el1
> - tbnz x2, #8, 2f // ISR_EL1.A
> + tbnz x2, #ISR_EL1_A_SHIFT, 2f
> ret
> nop
> 2:

Acked-by: Marc Zyngier <maz@kernel.org>

M.

--
Without deviation from the norm, progress is not possible.