From: Andrew Jones <andrew.jones@linux.dev>
To: Shaoqin Huang <shahuang@redhat.com>
Cc: kvmarm@lists.linux.dev, Nico Boehr <nrb@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Ricardo Koller <ricarkol@google.com>,
Sean Christopherson <seanjc@google.com>,
Colton Lewis <coltonlewis@google.com>,
Nikos Nikoleris <nikos.nikoleris@arm.com>,
Nina Schoetterl-Glausch <nsg@linux.ibm.com>,
kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v2 1/3] runtime: Fix the missing last_line
Date: Mon, 15 Jan 2024 13:26:15 +0100 [thread overview]
Message-ID: <20240115-8d47914acc8339f2fcc20807@orel> (raw)
In-Reply-To: <20231130032940.2729006-2-shahuang@redhat.com>
On Wed, Nov 29, 2023 at 10:29:38PM -0500, Shaoqin Huang wrote:
> The last_line is deleted by the 2607d2d6 ("arm64: Add an efi/run script").
> This lead to when SKIP test, the reason is missing. Fix the problem by
> adding last_line back.
>
> Fixes: 2607d2d6 ("arm64: Add an efi/run script")
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
> ---
> scripts/runtime.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
> index fc156f2f..c73fb024 100644
> --- a/scripts/runtime.bash
> +++ b/scripts/runtime.bash
> @@ -149,7 +149,7 @@ function run()
> fi
>
> if [ ${skip} == true ]; then
> - print_result "SKIP" $testname "" "$last_line"
> + print_result "SKIP" $testname "" "$(tail -1 <<<"$log")"
> return 77
> fi
> }
> --
> 2.40.1
>
Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
next prev parent reply other threads:[~2024-01-15 12:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 3:29 [kvm-unit-tests PATCH v2 0/3] arm64: runtime scripts improvements on efi Shaoqin Huang
2023-11-30 3:29 ` [kvm-unit-tests PATCH v2 1/3] runtime: Fix the missing last_line Shaoqin Huang
2024-01-15 12:26 ` Andrew Jones [this message]
2023-11-30 3:29 ` [kvm-unit-tests PATCH v2 2/3] runtime: arm64: Skip the migration tests when run on EFI Shaoqin Huang
2023-11-30 4:17 ` Shaoqin Huang
2024-01-15 12:25 ` Andrew Jones
2024-01-16 6:19 ` Shaoqin Huang
2023-11-30 3:29 ` [kvm-unit-tests PATCH v2 3/3] arm64: efi: Make running tests on EFI can be parallel Shaoqin Huang
2024-01-15 12:23 ` Andrew Jones
2024-01-16 6:37 ` Shaoqin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240115-8d47914acc8339f2fcc20807@orel \
--to=andrew.jones@linux.dev \
--cc=coltonlewis@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=nikos.nikoleris@arm.com \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
--cc=shahuang@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox