From: Andrew Jones <ajones@ventanamicro.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev,
kvm-riscv@lists.infradead.org, pbonzini@redhat.com,
maz@kernel.org, oliver.upton@linux.dev, anup@brainfault.org,
borntraeger@linux.ibm.com, frankja@linux.ibm.com,
imbrenda@linux.ibm.com
Subject: Re: Re: [PATCH 5/5] KVM: selftests: x86_64: Remove redundant newlines
Date: Wed, 31 Jan 2024 09:49:40 +0100 [thread overview]
Message-ID: <20240131-aaad2df64c2f26b892623006@orel> (raw)
In-Reply-To: <ZblbcUloeMqc-lR0@google.com>
On Tue, Jan 30, 2024 at 12:26:25PM -0800, Sean Christopherson wrote:
> On Wed, Dec 06, 2023, Andrew Jones wrote:
> > @@ -162,7 +162,7 @@ static void check_clocksource(void)
> > goto out;
> > }
> >
> > - TEST_ASSERT(!strncmp(clk_name, "tsc\n", st.st_size),
> > + TEST_ASSERT(!strncmp(clk_name, "tsc", st.st_size),
>
> This newline is functionally necessary. It's in the strncmp() (*#$@ sysfs appends
> newlines to everything), not the TEST_ASSERT message. I'll give you a pass and
> fixup when applying since I'm guessing you don't have x86 hardware ;-)
Thanks for the fixup!
>
> I double checked the other arch patches and didn't see anything sneaky like this.
And for the double check!
drew
next prev parent reply other threads:[~2024-01-31 8:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 17:02 [PATCH 0/5] KVM: selftests: Remove redundant newlines Andrew Jones
2023-12-06 17:02 ` [PATCH 1/5] " Andrew Jones
2023-12-06 17:02 ` [PATCH 2/5] KVM: selftests: aarch64: " Andrew Jones
2023-12-07 11:19 ` Zenghui Yu
2023-12-06 17:02 ` [PATCH 3/5] KVM: selftests: riscv: " Andrew Jones
2023-12-07 3:36 ` Anup Patel
2023-12-06 17:02 ` [PATCH 4/5] KVM: selftests: s390x: " Andrew Jones
2023-12-06 17:09 ` Claudio Imbrenda
2023-12-06 17:18 ` Janosch Frank
2023-12-06 17:02 ` [PATCH 5/5] KVM: selftests: x86_64: " Andrew Jones
2024-01-30 20:26 ` Sean Christopherson
2024-01-31 8:49 ` Andrew Jones [this message]
2023-12-06 17:07 ` [PATCH 0/5] KVM: selftests: " Andrew Jones
2024-01-31 0:59 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131-aaad2df64c2f26b892623006@orel \
--to=ajones@ventanamicro.com \
--cc=anup@brainfault.org \
--cc=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox