From: Andrew Jones <andrew.jones@linux.dev>
To: kvm@vger.kernel.org, kvmarm@lists.linux.dev
Cc: alexandru.elisei@arm.com, eric.auger@redhat.com,
nikos.nikoleris@arm.com, shahuang@redhat.com,
pbonzini@redhat.com, thuth@redhat.com
Subject: [kvm-unit-tests PATCH 01/14] runtime: Update MAX_SMP probe
Date: Fri, 23 Feb 2024 16:51:27 +0100 [thread overview]
Message-ID: <20240223155125.368512-17-andrew.jones@linux.dev> (raw)
In-Reply-To: <20240223155125.368512-16-andrew.jones@linux.dev>
Arm's MAX_SMP probing must have stopped working at some point due to
QEMU's error message changing, but nobody noticed. Also, the probing
should work for at least x86 now too, so the comment isn't correct
anymore either. We could probably just delete this probe thing, but
in case it could still serve some purpose we can also keep it, but
updated for later QEMU, and only enabled when a new run_tests.sh
command line option is provided.
Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
---
run_tests.sh | 5 ++++-
scripts/runtime.bash | 19 ++++++++++---------
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/run_tests.sh b/run_tests.sh
index abb0ab773362..bb3024ff95b1 100755
--- a/run_tests.sh
+++ b/run_tests.sh
@@ -44,7 +44,7 @@ fi
only_tests=""
list_tests=""
-args=$(getopt -u -o ag:htj:vl -l all,group:,help,tap13,parallel:,verbose,list -- $*)
+args=$(getopt -u -o ag:htj:vl -l all,group:,help,tap13,parallel:,verbose,list,probe-maxsmp -- $*)
[ $? -ne 0 ] && exit 2;
set -- $args;
while [ $# -gt 0 ]; do
@@ -78,6 +78,9 @@ while [ $# -gt 0 ]; do
-l | --list)
list_tests="yes"
;;
+ --probe-maxsmp)
+ probe_maxsmp
+ ;;
--)
;;
*)
diff --git a/scripts/runtime.bash b/scripts/runtime.bash
index c73fb0240d12..f2e43bb1ed60 100644
--- a/scripts/runtime.bash
+++ b/scripts/runtime.bash
@@ -200,12 +200,13 @@ function run()
#
# Probe for MAX_SMP, in case it's less than the number of host cpus.
#
-# This probing currently only works for ARM, as x86 bails on another
-# error first, so this check is only run for ARM and ARM64. The
-# parameter expansion takes the last number from the QEMU error
-# message, which gives the allowable MAX_SMP.
-if [[ $ARCH == 'arm' || $ARCH == 'arm64' ]] &&
- smp=$($RUNTIME_arch_run _NO_FILE_4Uhere_ -smp $MAX_SMP |& grep 'exceeds max CPUs'); then
- smp=${smp##*(}
- MAX_SMP=${smp:0:-1}
-fi
+function probe_maxsmp()
+{
+ local smp
+
+ if smp=$($RUNTIME_arch_run _NO_FILE_4Uhere_ -smp $MAX_SMP |& grep 'Invalid SMP CPUs'); then
+ smp=${smp##* }
+ echo "Restricting MAX_SMP from ($MAX_SMP) to the max supported ($smp)" >&2
+ MAX_SMP=$smp
+ fi
+}
--
2.43.0
next prev parent reply other threads:[~2024-02-23 15:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 15:51 [kvm-unit-tests PATCH 00/14] arm64: EFI improvements Andrew Jones
2024-02-23 15:51 ` Andrew Jones [this message]
2024-02-23 15:51 ` [kvm-unit-tests PATCH 02/14] runtime: Add yet another 'no kernel' error message Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 03/14] arm64: efi: Don't create dummy test Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 04/14] arm64: efi: Make running tests on EFI can be parallel Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 05/14] arm64: efi: Remove redundant dtb generation Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 06/14] arm64: efi: Move run code into a function Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 07/14] arm64: efi: Remove EFI_USE_DTB Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 08/14] arm64: efi: Improve device tree discovery Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 09/14] lib/efi: Add support for loading the initrd Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 10/14] arm64: efi: Allow running tests directly Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 11/14] arm/arm64: Factor out some initial setup Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 12/14] arm/arm64: Factor out allocator init from mem_init Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 13/14] arm64: Simplify efi_mem_init Andrew Jones
2024-02-23 15:51 ` [kvm-unit-tests PATCH 14/14] arm64: Add memregions_efi_init Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223155125.368512-17-andrew.jones@linux.dev \
--to=andrew.jones@linux.dev \
--cc=alexandru.elisei@arm.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=nikos.nikoleris@arm.com \
--cc=pbonzini@redhat.com \
--cc=shahuang@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox