From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFE41155A30 for ; Fri, 26 Jul 2024 23:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722037968; cv=none; b=czd54OITveV2RX8SHsteiGg3G6wIzMkl2nSbZNVM4F3mJ3z1o2lMvWIpUp+dL01HMB6Y6B+xrjGAKuVfB45XLAveZuCRK/8Naob8EoiINkUeFE7EaQtvrIPIK0SV9fRRalxXOpvFEAPnsayx/cJFmWGKE1pWlEylQNPaChDrnqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722037968; c=relaxed/simple; bh=nMIA0IB61sSIVDFSpMoIESja3SRG4qTvpXk7E9I+g3Y=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=AYUvriWhLLP32KFUBphkHDXGcPEbp63fU73Equ+KRSQoUPSwpzLT1+Pjv0jRSz/ysCOIXAkh6ECOxrtko25kqdd4K5BhcJwJQ/F6GrdK+kILeiVGVCytjVbQHtisHPXdWvcW/UHif9VSKqDageViA3Y1QRSu7d8L2WCBB7h9rvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=u3rP+oUf; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u3rP+oUf" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-70d1c8d98baso1424301b3a.3 for ; Fri, 26 Jul 2024 16:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722037966; x=1722642766; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=xiBZUTde5/yOu+VhqaXt4CYe/LeOwSdHW5ydN5gOuKQ=; b=u3rP+oUf2hy9GISbCgFgE0CGwSpa0G9pk9Gf1DObUVLYmb8W2T3V/478EwHQVAdIfp +OsJ+2+FhOSE1Adu1nXA/RLYCyLHEys+Jy9vEecOwXZHFctK7X+8kfEXdWU/hrQUOR+k A7/OhPBO06asBX225ocbq8tdh7dPMQBEzS84zR6+a3BYVuJQKnKbfwStDKA3Po6UVN5R RFuGN589fbVFr9bcYp4WhufmTSjRFzsxx7mOzMEtaAvvwpTRIx5RY0vEvkGjWztlobWc 1cfdGGvSyBdhbdf+XqEy1G2ygV2pDYyOYLXR0gmO7SmEdJpJ6vkPLIfx+mmsJy8N38te Q9bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722037966; x=1722642766; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xiBZUTde5/yOu+VhqaXt4CYe/LeOwSdHW5ydN5gOuKQ=; b=r0s8aIkmwfYVHYVQKwYmHPHeUE/nt8Yg7riK/9BknGvwSWTLbbbSP1C8CgyESfaabC /B6WS3CS532z1xYS9oZGoVRfe0lV/seRcYlrPa6ucCIwy6+WGJPIwazScxWiC6WDgMWt YXWo18WBfcCcyMftArq6OJoRV1ShnFH41PcNaejGfUv4ovZx6nRwnfnkStyvT2MhMjRJ DBHMlNt9soCCwU0JoRKXDozQMMWgoWuprYjz4vAYYvnSg+DH2kEXWwxf60ho963MdJ94 LjnKw043W2lOO1wKk7kCQXtt1JB4zfGtYQP3ooLq4tnry8gelz1O3kgA/TspozRTSh/b YBvA== X-Forwarded-Encrypted: i=1; AJvYcCVaRg/sI6wnVkg6zIQFySAOHwbdELs1MWqAn97X6o7K/6VGz87zhntA26LFSJ0tfTjOLDvJ1zJUOrkDYdNZ//AhQj2lnnfd X-Gm-Message-State: AOJu0YyyKlsnVErs//vBwf2uymroQod+NxTWo/E3d2zraeO4kddSjYP1 TIZSZYeO0PqYPcjak0MEpDmFzZLZ+UGBJ4DD31FVfwPX5HxlEPCWGP74Kch2DjkdKta9shWnEBC 66w== X-Google-Smtp-Source: AGHT+IFeDzTSYc0yloJqv412y/9OHddQLGngXAZq8SjSSTQr+cl72qk3J3BVbl3XjHWFKDqTN/CvEh64V1I= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:8703:b0:70d:1285:bbcf with SMTP id d2e1a72fcca58-70ece93a09amr3050b3a.0.1722037965825; Fri, 26 Jul 2024 16:52:45 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 26 Jul 2024 16:51:13 -0700 In-Reply-To: <20240726235234.228822-1-seanjc@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240726235234.228822-1-seanjc@google.com> X-Mailer: git-send-email 2.46.0.rc1.232.g9752f9e123-goog Message-ID: <20240726235234.228822-5-seanjc@google.com> Subject: [PATCH v12 04/84] KVM: Allow calling kvm_release_page_{clean,dirty}() on a NULL page pointer From: Sean Christopherson To: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Content-Type: text/plain; charset="UTF-8" Allow passing a NULL @page to kvm_release_page_{clean,dirty}(), there's no tangible benefit to forcing the callers to pre-check @page, and it ends up generating a lot of duplicate boilerplate code. Signed-off-by: Sean Christopherson --- virt/kvm/kvm_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index fd8c212b8de7..656e931ac39e 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -3186,7 +3186,7 @@ static void kvm_set_page_accessed(struct page *page) void kvm_release_page_clean(struct page *page) { - if (WARN_ON(!page)) + if (!page) return; kvm_set_page_accessed(page); @@ -3211,7 +3211,7 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_clean); void kvm_release_page_dirty(struct page *page) { - if (WARN_ON(!page)) + if (!page) return; kvm_set_page_dirty(page); -- 2.46.0.rc1.232.g9752f9e123-goog