From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5BA51CEEBE for ; Thu, 10 Oct 2024 18:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728584695; cv=none; b=gb45T2q7ErNZDblMT7X+tlqBG50FrIAI0toFIJrLFKLNwKPVbl13XW3N9p6OC3qhYDqc8rOy0QtGEKQ1+7DsRD4xw5RB/E3TdXdnSWUaQ4UNHk5VCErAlh7F2Tu1SnXS1Z29I1wAW+OD6Bn2Wd93wWh6vhitjphbnRTf8+qqs1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728584695; c=relaxed/simple; bh=GKQ1+9zVatIXCwDEsM6DNkbKcmF2enzdpw2dYi1+r2s=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=auVa3MOmcK593IE1U/A3HzVDtADJou73M0JSjDvHlKQ3OU7EFLCjJx7SxSI6RWzXl/qWKl2fqxByza5hBU1V9nsCEhhTTtD+jNeP0D/LRvLOfe3s0DMYNIHSfNUXTdz/wPLohgLokNt8ac468m6BDz2uMNrX3wNVTKpXqmaNhgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=TNYtrAcw; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TNYtrAcw" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-20c94c1f692so4778125ad.1 for ; Thu, 10 Oct 2024 11:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728584693; x=1729189493; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:from:to:cc:subject:date :message-id:reply-to; bh=yUMe47Ku2d+lU53n+UV6eA4G9zH9pOaBnB7PUsg7n0E=; b=TNYtrAcwNk0sf8D42v+j8YCO5+m/01h8wD3gW0qu3ZcKGBxEwN96EeTPjFpL8uA2oP 6bFBYyBUOz7xgPfRUKl2vmdm8gD7410Wyt14MeRQ0pTO2QZTE4tIiCf9easKMshFNQU8 5xo/28+R9s64yqoqueuFtiyCXXoJLu+TKkDdYdlOqEiay/z9hiiZZz5F8diHf939ZNma VJ4RiOs5jNTJAsZc85cw2WOoPwg4OyEBHENks7UIh9GwuvsqDBs/7TWspXb7fb+Htvuv iQYZhjAy6DHz5LRIpblHgG8TtwZF+YUlr2XfGaHRZczwKj297FZJaunbPKU1EV5YV6pA Bo6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728584693; x=1729189493; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yUMe47Ku2d+lU53n+UV6eA4G9zH9pOaBnB7PUsg7n0E=; b=v/w0utLj8BKfJc04/AbXLKNjcGwQP8ik0CrnbHzD16p1qQyj33OA1XuRU+XwquSvv0 GG6b52llMu2LKCLKbsS/lDEEJ+Se5sYtbBBlwKWUvJXNBlzPvThGHJPLrwtdVjj05dtX azj7qBd1NF5lpcJsd1BF/9xgYepwyLnQARfy1amo+xjoR3OuaT6HxU179o96jFnwMX4h +Mu4u5K8hubtkpSoO8f41hAqT78IBjMNYZo3zfNDzIdpsvy74qb8flLLGGeGvDIeFrHr LQbYDbpLyp1v/K/KnMTlLn3SkNMH4mlabwQpMPj4/H0A6u8VwZIyVoUzotcES17qnKGu UnFw== X-Forwarded-Encrypted: i=1; AJvYcCV97KVF6TQyj8CdedKJrMvkjUt+Zgp0GNn/NWL324HOaLMDGA2oGsES9D2zEbeI3Z8oTICIjd8=@lists.linux.dev X-Gm-Message-State: AOJu0YxrO9ToED4rOOlzIopFhYD7btmFMkN43+DB0yVUzKWHLbHplL4i SGOQe82lQL+L3KAAlwI+YLanZKAklo1KYKKINgQ272n2YLPrp8k+gLuzq2Z5nxQao93SlTTDf0a isQ== X-Google-Smtp-Source: AGHT+IHgBvu4/6UpOEaDnS659CK1Rn1/E5r8mTk00ZsUtMRUIXJafj8Ignnkw5WxXqtPYIrr50vXY4UIGHU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a17:902:ff02:b0:205:58ee:1567 with SMTP id d9443c01a7336-20c80362278mr43175ad.0.1728584692824; Thu, 10 Oct 2024 11:24:52 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 10 Oct 2024 11:23:04 -0700 In-Reply-To: <20241010182427.1434605-1-seanjc@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241010182427.1434605-1-seanjc@google.com> X-Mailer: git-send-email 2.47.0.rc1.288.g06298d1525-goog Message-ID: <20241010182427.1434605-3-seanjc@google.com> Subject: [PATCH v13 02/85] KVM: Allow calling kvm_release_page_{clean,dirty}() on a NULL page pointer From: Sean Christopherson To: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, "=?UTF-8?q?Alex=20Benn=C3=A9e?=" , Yan Zhao , David Matlack , David Stevens , Andrew Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Allow passing a NULL @page to kvm_release_page_{clean,dirty}(), there's no tangible benefit to forcing the callers to pre-check @page, and it ends up generating a lot of duplicate boilerplate code. Reviewed-by: Alex Benn=C3=A9e Tested-by: Alex Benn=C3=A9e Signed-off-by: Sean Christopherson --- virt/kvm/kvm_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 4b659a649dfa..2032292df0b0 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -3179,7 +3179,7 @@ static void kvm_set_page_accessed(struct page *page) =20 void kvm_release_page_clean(struct page *page) { - if (WARN_ON(!page)) + if (!page) return; =20 kvm_set_page_accessed(page); @@ -3204,7 +3204,7 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_clean); =20 void kvm_release_page_dirty(struct page *page) { - if (WARN_ON(!page)) + if (!page) return; =20 kvm_set_page_dirty(page); --=20 2.47.0.rc1.288.g06298d1525-goog