From: Oliver Upton <oliver.upton@linux.dev>
To: kvmarm@lists.linux.dev
Cc: Marc Zyngier <maz@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Oliver Upton <oliver.upton@linux.dev>
Subject: [PATCH 0/2] KVM: arm64: Fix splat/misbehavior for MMIO SEA injection
Date: Fri, 18 Oct 2024 19:47:55 +0000 [thread overview]
Message-ID: <20241018194757.3685856-1-oliver.upton@linux.dev> (raw)
syzkaller continues to find more interesting bugs, this time due to a
decently-sized hole in our UAPI.
Turns out we still go through the motions of completing MMIO emulation
even if userspace has pended a *synchronous* external abort in response
to an unexpected access. Oops!
In addition to the fix, I felt this warranted a selftest because a
documented UAPI flow has been broken for a while.
Marc, I'll probably take this in 6.13 since we've still got quite a bit
outstanding for 6.12 and this isn't *terribly* urgent.
Oliver Upton (2):
KVM: arm64: Don't retire aborted MMIO instruction
KVM: arm64: selftests: Add tests for MMIO external abort injection
arch/arm64/include/asm/kvm_emulate.h | 25 +++
arch/arm64/kvm/mmio.c | 7 +-
tools/testing/selftests/kvm/Makefile | 1 +
.../selftests/kvm/aarch64/mmio_abort.c | 158 ++++++++++++++++++
4 files changed, 189 insertions(+), 2 deletions(-)
create mode 100644 tools/testing/selftests/kvm/aarch64/mmio_abort.c
base-commit: 78a00555550042ed77b33ace7423aced228b3b4e
--
2.47.0.rc1.288.g06298d1525-goog
next reply other threads:[~2024-10-18 19:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 19:47 Oliver Upton [this message]
2024-10-18 19:47 ` [PATCH 1/2] KVM: arm64: Don't retire aborted MMIO instruction Oliver Upton
2024-10-19 9:10 ` Marc Zyngier
2024-10-19 18:13 ` Oliver Upton
2024-10-18 19:47 ` [PATCH 2/2] KVM: arm64: selftests: Add tests for MMIO external abort injection Oliver Upton
2024-10-18 21:03 ` Oliver Upton
2024-10-19 9:16 ` [PATCH 0/2] KVM: arm64: Fix splat/misbehavior for MMIO SEA injection Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018194757.3685856-1-oliver.upton@linux.dev \
--to=oliver.upton@linux.dev \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox