Linux KVM/arm64 development list
 help / color / mirror / Atom feed
From: Fuad Tabba <tabba@google.com>
To: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Cc: maz@kernel.org, oliver.upton@linux.dev, james.clark@linaro.org,
	 will@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com,
	 yuzenghui@huawei.com, catalin.marinas@arm.com,
	broonie@kernel.org,  qperret@google.com,
	kristina.martsenko@arm.com, tabba@google.com
Subject: [PATCH v4 12/14] KVM: arm64: Fix the value of the CPTR_EL2 RES1 bitmask for nVHE
Date: Mon,  2 Dec 2024 15:47:39 +0000	[thread overview]
Message-ID: <20241202154742.3611749-13-tabba@google.com> (raw)
In-Reply-To: <20241202154742.3611749-1-tabba@google.com>

Since the introduction of SME, bit 12 in CPTR_EL2 (nVHE) is TSM
for trapping SME, instead of RES1, as per ARM ARM DDI 0487K.a,
section D23.2.34.

Fix the value of CPTR_NVHE_EL2_RES1 to reflect that, and adjust
the code that relies on it accordingly.

Signed-off-by: Fuad Tabba <tabba@google.com>
---
 arch/arm64/include/asm/kvm_arm.h     | 2 +-
 arch/arm64/include/asm/kvm_emulate.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h
index 3e0f0de1d2da..24e4ac7c50f2 100644
--- a/arch/arm64/include/asm/kvm_arm.h
+++ b/arch/arm64/include/asm/kvm_arm.h
@@ -300,7 +300,7 @@
 #define CPTR_EL2_TSM	(1 << 12)
 #define CPTR_EL2_TFP	(1 << CPTR_EL2_TFP_SHIFT)
 #define CPTR_EL2_TZ	(1 << 8)
-#define CPTR_NVHE_EL2_RES1	0x000032ff /* known RES1 bits in CPTR_EL2 (nVHE) */
+#define CPTR_NVHE_EL2_RES1	(BIT(13) | BIT(9) | GENMASK(7, 0))
 #define CPTR_NVHE_EL2_RES0	(GENMASK(63, 32) |	\
 				 GENMASK(29, 21) |	\
 				 GENMASK(19, 14) |	\
diff --git a/arch/arm64/include/asm/kvm_emulate.h b/arch/arm64/include/asm/kvm_emulate.h
index 7b3dc52248ce..6602a4c091ac 100644
--- a/arch/arm64/include/asm/kvm_emulate.h
+++ b/arch/arm64/include/asm/kvm_emulate.h
@@ -640,8 +640,8 @@ static __always_inline void kvm_reset_cptr_el2(struct kvm_vcpu *vcpu)
 
 		if (vcpu_has_sve(vcpu) && guest_owns_fp_regs())
 			val |= CPTR_EL2_TZ;
-		if (cpus_have_final_cap(ARM64_SME))
-			val &= ~CPTR_EL2_TSM;
+		if (!cpus_have_final_cap(ARM64_SME))
+			val |= CPTR_EL2_TSM;
 	}
 
 	kvm_write_cptr_el2(val);
-- 
2.47.0.338.g60cca15819-goog


  parent reply	other threads:[~2024-12-02 15:48 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 15:47 [PATCH v4 00/14] KVM: arm64: Rework guest VM fixed feature handling and trapping in pKVM Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 01/14] KVM: arm64: Consolidate allowed and restricted VM feature checks Fuad Tabba
2024-12-06 16:12   ` Quentin Perret
2024-12-09  8:03     ` Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 02/14] KVM: arm64: Group setting traps for protected VMs by control register Fuad Tabba
2024-12-06 16:44   ` Quentin Perret
2024-12-09  8:06     ` Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 03/14] KVM: arm64: Move checking protected vcpu features to a separate function Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 04/14] KVM: arm64: Use KVM extension checks for allowed protected VM capabilities Fuad Tabba
2024-12-06 17:10   ` Quentin Perret
2024-12-09  8:14     ` Fuad Tabba
2024-12-11 13:29       ` Quentin Perret
2024-12-11 13:30         ` Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 05/14] KVM: arm64: Initialize feature id registers for protected VMs Fuad Tabba
2024-12-06  1:02   ` Oliver Upton
2024-12-06 10:04     ` Fuad Tabba
2024-12-06 17:13   ` Quentin Perret
2024-12-09  8:09     ` Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 06/14] KVM: arm64: Set protected VM traps based on its view of feature registers Fuad Tabba
2024-12-06 17:31   ` Quentin Perret
2024-12-06 17:43     ` Mark Brown
2024-12-06 18:22       ` Marc Zyngier
2024-12-09  8:11         ` Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 07/14] KVM: arm64: Rework specifying restricted features for protected VMs Fuad Tabba
2024-12-11 12:34   ` Quentin Perret
2024-12-11 13:11     ` Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 08/14] KVM: arm64: Remove fixed_config.h header Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 09/14] KVM: arm64: Remove redundant setting of HCR_EL2 trap bit Fuad Tabba
2024-12-11 12:38   ` Quentin Perret
2024-12-11 12:52     ` Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 10/14] KVM: arm64: Calculate cptr_el2 traps on activating traps Fuad Tabba
2024-12-11 12:46   ` Quentin Perret
2024-12-11 12:55     ` Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 11/14] KVM: arm64: Refactor kvm_reset_cptr_el2() Fuad Tabba
2024-12-02 15:47 ` Fuad Tabba [this message]
2024-12-02 15:47 ` [PATCH v4 13/14] KVM: arm64: Remove PtrAuth guest vcpu flag Fuad Tabba
2024-12-02 15:47 ` [PATCH v4 14/14] KVM: arm64: Convert the SVE guest vcpu flag to a vm flag Fuad Tabba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241202154742.3611749-13-tabba@google.com \
    --to=tabba@google.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=james.clark@linaro.org \
    --cc=joey.gouly@arm.com \
    --cc=kristina.martsenko@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=qperret@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox