From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B03A2FE33B for ; Thu, 17 Jul 2025 16:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752769666; cv=none; b=HixUuBH6J8klnk30dM+3z9TdFCXcX95XOjIiVd823JSci5LWvw8MU5LYcD8ydv0lvVltvRZdRKGp5D86a+IeKPVUaZzwuGZi1fli5ceLOErvskOFt+ofCo+dhTV/Ll0/FbBnPO7rIdPK8PooVy1z5clI62kOLLnn5SgxmfBDYQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752769666; c=relaxed/simple; bh=5SFcmIaZT18BqEoeZQIYRV1Aqypru/hVXQDtZkdpxP8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=l1fvWsIXaKiZCk3T7eKMHNGHWlGYx466nXlcdRDkYzPloX6u/t4LSF0url4md9dYU+kar/sTWPD3dJ7aW/1/zfP8Mz2YhMo/N8g8hGBM6VzTgG914lVlcUiU816ffQggILPjuYBFvpPPDbr+moA8zc5WgMVA4qxU7YvaKOat6BU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tabba.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eTn626M/; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tabba.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eTn626M/" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-453817323afso8076025e9.1 for ; Thu, 17 Jul 2025 09:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752769663; x=1753374463; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=NswHrgkdcqxmOhQmg+I1ZftODzAqq/smUBNc/8jSsg0=; b=eTn626M/EUsB+0wWp5wNuMaibPSka0ECUhtpq+yUevbBjUkA4TPeIgPigoFXUidxys pKpL7N97c4of6zNCJ7PMaU6hLSdrsyMCHJlL/+QtsbkFBRfBV6mZb9a3vL9pjrQ/DFPY gGw4jHgUb1g6Kd6b+5ZrWnRRTupb1zNhMs1bFa9w06ko0EqLHH7FgEsJtMWTFRaqIfrJ FCNIdFcllPDbmgriu3Ud3sJwnygcTmQdZ1rRjvx1V/uAQzd7HhBepzU/of58BCVqN9Bu yXURtkDZF3SG08pd97oorPmpkjmgDbTr4s+Bm+6ebhUn9TFkgHdwyY2bdnbYn28MAjkr 6YTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752769663; x=1753374463; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NswHrgkdcqxmOhQmg+I1ZftODzAqq/smUBNc/8jSsg0=; b=TPhQi0FLsqNthY+uR5MGzqJFMrNhCxXIvMmzrt8E+yF86dvO/M7kLJ3FQffI7JrOWu KEUIH0phqesTxUFaABbkI9DKLj5XBS4S2E9rNjR+YkQMNxmFb99NceXvkdTHjf1dLDo5 TFerSC5g+RE78insqXOz9/pTzExdW6UkeR/xSM/pCPztNG7rwd17ME+n4FCk79pQfdr+ Q1pEHy8I62HdoTNWDdQLUnLoV7Zpx7Lb3akQmKlp9Wq6OEKK2IzsynWZE1307GcB4t6a 7FxBqewa+4KfvZeyZpScDoOJISXnfq/7q8imdPd7ekmvgHCbU1sfqMd6VQpJGlkDzLRe dW+w== X-Forwarded-Encrypted: i=1; AJvYcCWp/GGmNK4I5rbnnWpe4rrb1CnXXpkf0zRZk1jlCmVQpPABD3mQYYwBFu+OIdshCpjufFbBIg4=@lists.linux.dev X-Gm-Message-State: AOJu0YwLrkj/ebKp0ttOYE/tXKdmu0AR+JD/QRw1PVY7YOf15I3EsaXw eMRC8x+erbPWlJTEQW+Qw7Lf22aaJLJ4JFIsG7ygRS6H2Vf2juqkmxuzsq8GvXnF3TGq/sOhlgN l/Q== X-Google-Smtp-Source: AGHT+IFgMT0SNfYFF6wTIOhI0LgfBaX0JYI2vvKy+B/T/ROVKWlCDpvfTeMqXVsxiyrC4q2xBnylePD55Q== X-Received: from wmbdq15.prod.google.com ([2002:a05:600c:64cf:b0:456:1518:6d6e]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b9d:b0:456:26a1:a0c1 with SMTP id 5b1f17b1804b1-4562e274a82mr91598805e9.17.1752769663500; Thu, 17 Jul 2025 09:27:43 -0700 (PDT) Date: Thu, 17 Jul 2025 17:27:21 +0100 In-Reply-To: <20250717162731.446579-1-tabba@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250717162731.446579-1-tabba@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250717162731.446579-12-tabba@google.com> Subject: [PATCH v15 11/21] KVM: x86/mmu: Allow NULL-able fault in kvm_max_private_mapping_level From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com, tabba@google.com Content-Type: text/plain; charset="UTF-8" From: Ackerley Tng Refactor kvm_max_private_mapping_level() to accept a NULL kvm_page_fault pointer and rename it to kvm_gmem_max_mapping_level(). The max_mapping_level x86 operation (previously private_max_mapping_level) is designed to potentially be called without an active page fault, for instance, when kvm_mmu_max_mapping_level() is determining the maximum mapping level for a gfn proactively. Allow NULL fault pointer: Modify kvm_max_private_mapping_level() to safely handle a NULL fault argument. This aligns its interface with the kvm_x86_ops.max_mapping_level operation it wraps, which can also be called with NULL. Rename function to kvm_gmem_max_mapping_level(): This reinforces that the function's scope is for guest_memfd-backed memory, which can be either private or non-private, removing any remaining "private" connotation from its name. Optimize max_level checks: Introduce a check in the caller to skip querying for max_mapping_level if the current max_level is already PG_LEVEL_4K, as no further reduction is possible. Acked-by: David Hildenbrand Suggested-by: Sean Christoperson Signed-off-by: Ackerley Tng Signed-off-by: Fuad Tabba --- arch/x86/kvm/mmu/mmu.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index bb925994cbc5..6bd28fda0fd3 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -4467,17 +4467,13 @@ static inline u8 kvm_max_level_for_order(int order) return PG_LEVEL_4K; } -static u8 kvm_max_private_mapping_level(struct kvm *kvm, - struct kvm_page_fault *fault, - int gmem_order) +static u8 kvm_gmem_max_mapping_level(struct kvm *kvm, int order, + struct kvm_page_fault *fault) { - u8 max_level = fault->max_level; u8 req_max_level; + u8 max_level; - if (max_level == PG_LEVEL_4K) - return PG_LEVEL_4K; - - max_level = min(kvm_max_level_for_order(gmem_order), max_level); + max_level = kvm_max_level_for_order(order); if (max_level == PG_LEVEL_4K) return PG_LEVEL_4K; @@ -4513,7 +4509,9 @@ static int kvm_mmu_faultin_pfn_private(struct kvm_vcpu *vcpu, } fault->map_writable = !(fault->slot->flags & KVM_MEM_READONLY); - fault->max_level = kvm_max_private_mapping_level(vcpu->kvm, fault, max_order); + if (fault->max_level >= PG_LEVEL_4K) + fault->max_level = kvm_gmem_max_mapping_level(vcpu->kvm, + max_order, fault); return RET_PF_CONTINUE; } -- 2.50.0.727.gbf7dc18ff4-goog