From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D849289815 for ; Tue, 5 Aug 2025 15:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754409272; cv=none; b=ETEI4zn+tDN0NMif0IZku2crCLihmOVLJhKTx/Z0Uz/rjr3jlDLWogMrpR4/LKrvuwKTmUKCz/V/J4MCMMeAAl8vETQmvoYnS72aJAMUeTWgklwlHETHKnlpDgzS7VLQB6czoZGwwtDN6XR3CE4o1SkGyYWSkctVvzYtiVYc4fY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754409272; c=relaxed/simple; bh=/OzaxpwEfK7AcyjcWdiVUrxbZQFVcmCDmajtf4oAfG8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A+KBZTsbS1gdNHQ9FmaEqmovwIVH3hCTgac0CvO0JBiUmPlREbqSsmR6S6KJgicO9YxOSPQAjKe85qZh3leI0R3g3DgdmTkRUR+4G8p/b63PlhvHgHcNvnTKyKKQo/bLuVChfVXV8GUjQcXFGz5A4r91o4LhPygvq9mmGiG3bx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=n88r/LTx; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="n88r/LTx" Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-707389a2fe3so55710396d6.2 for ; Tue, 05 Aug 2025 08:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1754409270; x=1755014070; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qmi6Xyv0QvJ7lU7CctnLT4GD6xbprG8jnHy2E/XWXdI=; b=n88r/LTxe5C8X9QFP7inFHWtfonuCqGH0HPg4PcRJBFW/nlu9FIjSRed8ix/kG+Faz BDgjTxyQl0GnviBUa4dG4y3wdwgaViLs9ejq4YHViRSe3TF64LUe7fW+hU72TQE0lMbn DOO911/+ys5oVgVbbbDGfQlJ2s2zRfS1llmXTApFmhzjEFsAZ98I3+UW/LwBkg9FpNlr P7DvnkO54hPmzP4Cc6K34nVEC3p8Rk2IG1aCtbUdfwKhEaxUYFOv15SFbE1ggFEPiP0B ykXzgw7gJ7AwMgzVt7jMZuq/JH+dPU1kRSYfunUGCZx21CfwWpcwyGGutuBc2FvbRbP8 qUjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754409270; x=1755014070; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qmi6Xyv0QvJ7lU7CctnLT4GD6xbprG8jnHy2E/XWXdI=; b=JR1YQqS9J7qD/M+EMkcHQfc2G+MVTHO7Y1U4FxVNjVN1WWAoYMqUGC8sN3ANPET2Vj Efvd9sD3txHIqeLBHH2FjMj96+bv3M4O4HSEITo3nEPZOQIURtcGGkg6ffmSRMweRVl5 1TNqX75LAOomGTEF8R2Po4dyfE0nS+xtQWlGyn+4zDjNCJGqdGouuSVrFIo2U5aMFyW5 q5YYdos+a0HwDlnwuSOMYpA53Kkg4+f6GDJJK1SsN6DpnNbkaxsyIWQ56xNhdsUoAGZF afJqV/BoFf1YKFfkCeD1dknKTLp1LWr4DUs4nZ4gDY3WSJCLLIkDmKknIoyTgjw8NLet MU6g== X-Forwarded-Encrypted: i=1; AJvYcCUKUTZ6MY2jif26G2wF6A1er/VHMxSd/EDUUOVBdlfdIxd1eGEhrCbYHPaPFAtKOKRVxGhQqtA=@lists.linux.dev X-Gm-Message-State: AOJu0YwphvLuKP/fLNmco4s2A6YCuJBoOeQrteWHelGmGixZouvmVZlg 8Crh4i3IBhk5APH+AQRjvJRh7hOO3qLU9RP7cW4d7OXBPsGuvg7HM2iB+qyf2EYCOLY= X-Gm-Gg: ASbGncstWkvHVFRM+XQ9NEYskcvEJXOQtixQDVDRQuqM46F6w5BONsNOfBT5lw2X44U 7Ol/w01SZrGRnae7MnwOhO+Kf2l0Xa68CUZhK/ABJbBFB11LVJhK4BMYE/1YAxK/aZy+Sh0KOWf Xt2tUH8w/AmGwWgo9eg3dQ7okkceVM8fshHOaudhxEc3zqz8XSQIYlozvSVYrYZfOVfsWjOmjJX 59gYu2Lmyvr/B0IamXh5wbxsm2MOrjJhrl8UdpdzJB/37w78HD/r5arX4NPRB0IQIzKL48WHGWN /p4SeWwqFZCDEL5Ya6vuVT9JIZxvMF22AFp2S9yJYOPjBatBT0seH44lUDuWCY1xFQripE3amQJ b2NwCNaAT+G84YngMrQJdTCrPk/f3LmVvMt79Br+eFy5eoVkRr8URgfOeGms0iKzVD4wp X-Google-Smtp-Source: AGHT+IEbopEuDV++hnxNrBy6jE94j7fNSg5OYfawZGMmOOqA+BK3PuMzmdEKgi6bq4gnWI1YvySFkw== X-Received: by 2002:a05:6214:2a4c:b0:707:635f:67c3 with SMTP id 6a1803df08f44-70935f79001mr202676776d6.14.1754409269871; Tue, 05 Aug 2025 08:54:29 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077ce37c01sm73097906d6.79.2025.08.05.08.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Aug 2025 08:54:29 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1ujJzg-00000001YhL-3W2I; Tue, 05 Aug 2025 12:54:28 -0300 Date: Tue, 5 Aug 2025 12:54:28 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V" Cc: linux-coco@lists.linux.dev, kvmarm@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, aik@amd.com, lukas@wunner.de, Samuel Ortiz , Xu Yilun , Suzuki K Poulose , Steven Price , Catalin Marinas , Marc Zyngier , Will Deacon , Oliver Upton Subject: Re: [RFC PATCH v1 04/38] tsm: Support DMA Allocation from private memory Message-ID: <20250805155428.GU26511@ziepe.ca> References: <20250728135216.48084-1-aneesh.kumar@kernel.org> <20250728135216.48084-5-aneesh.kumar@kernel.org> <20250728143318.GD26511@ziepe.ca> <20250729143339.GH26511@ziepe.ca> <20250802134154.GI26511@ziepe.ca> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Aug 04, 2025 at 12:28:33PM +0530, Aneesh Kumar K.V wrote: > Note that we don’t update the phys_addr_t to set the top > bit. For reference: > > tlb_addr = slot_addr(pool->start, index) + offset; This seems unfortunate. So you end up with the private IPA space having shared pages in it, so *sometimes* you have to force the unencrypted bit? Seems to me we should insist the phys_addr is cannonised before reaching the dma API. Ie that the swiotlb/etc code will set the right IPA bit. Jason