Linux KVM/arm64 development list
 help / color / mirror / Atom feed
From: "Roy, Patrick" <roypat@amazon.co.uk>
To: "david@redhat.com" <david@redhat.com>,
	"seanjc@google.com" <seanjc@google.com>
Cc: "Roy, Patrick" <roypat@amazon.co.uk>,
	"tabba@google.com" <tabba@google.com>,
	"ackerleytng@google.com" <ackerleytng@google.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"kvmarm@lists.linux.dev" <kvmarm@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"rppt@kernel.org" <rppt@kernel.org>,
	"will@kernel.org" <will@kernel.org>,
	"vbabka@suse.cz" <vbabka@suse.cz>,
	"Cali, Marco" <xmarcalx@amazon.co.uk>,
	"Kalyazin, Nikita" <kalyazin@amazon.co.uk>,
	"Thomson, Jack" <jackabt@amazon.co.uk>,
	"Manwaring, Derek" <derekmn@amazon.com>
Subject: [PATCH v5 02/12] arch: export set_direct_map_valid_noflush to KVM module
Date: Thu, 28 Aug 2025 09:39:17 +0000	[thread overview]
Message-ID: <20250828093902.2719-3-roypat@amazon.co.uk> (raw)
In-Reply-To: <20250828093902.2719-1-roypat@amazon.co.uk>

Use the new per-module export functionality to allow KVM (and only KVM)
access to set_direct_map_valid_noflush(). This allows guest_memfd to
remove its memory from the direct map, even if KVM is built as a module.

Direct map removal gives guest_memfd the same protection that
memfd_secret enjoys, such as hardening against Spectre-like attacks
through in-kernel gadgets.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
---
 arch/arm64/mm/pageattr.c     | 1 +
 arch/loongarch/mm/pageattr.c | 1 +
 arch/riscv/mm/pageattr.c     | 1 +
 arch/s390/mm/pageattr.c      | 1 +
 arch/x86/mm/pat/set_memory.c | 1 +
 5 files changed, 5 insertions(+)

diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
index 04d4a8f676db..4f3cddfab9b0 100644
--- a/arch/arm64/mm/pageattr.c
+++ b/arch/arm64/mm/pageattr.c
@@ -291,6 +291,7 @@ int set_direct_map_valid_noflush(struct page *page, unsigned nr, bool valid)
 
 	return set_memory_valid(addr, nr, valid);
 }
+EXPORT_SYMBOL_FOR_MODULES(set_direct_map_valid_noflush, "kvm");
 
 #ifdef CONFIG_DEBUG_PAGEALLOC
 /*
diff --git a/arch/loongarch/mm/pageattr.c b/arch/loongarch/mm/pageattr.c
index f5e910b68229..d076bfd3fcbf 100644
--- a/arch/loongarch/mm/pageattr.c
+++ b/arch/loongarch/mm/pageattr.c
@@ -217,6 +217,7 @@ int set_direct_map_invalid_noflush(struct page *page)
 
 	return __set_memory(addr, 1, __pgprot(0), __pgprot(_PAGE_PRESENT | _PAGE_VALID));
 }
+EXPORT_SYMBOL_FOR_MODULES(set_direct_map_valid_noflush, "kvm");
 
 int set_direct_map_valid_noflush(struct page *page, unsigned nr, bool valid)
 {
diff --git a/arch/riscv/mm/pageattr.c b/arch/riscv/mm/pageattr.c
index 3f76db3d2769..6db31040cd66 100644
--- a/arch/riscv/mm/pageattr.c
+++ b/arch/riscv/mm/pageattr.c
@@ -400,6 +400,7 @@ int set_direct_map_valid_noflush(struct page *page, unsigned nr, bool valid)
 
 	return __set_memory((unsigned long)page_address(page), nr, set, clear);
 }
+EXPORT_SYMBOL_FOR_MODULES(set_direct_map_valid_noflush, "kvm");
 
 #ifdef CONFIG_DEBUG_PAGEALLOC
 static int debug_pagealloc_set_page(pte_t *pte, unsigned long addr, void *data)
diff --git a/arch/s390/mm/pageattr.c b/arch/s390/mm/pageattr.c
index 348e759840e7..8ffd9ef09bc6 100644
--- a/arch/s390/mm/pageattr.c
+++ b/arch/s390/mm/pageattr.c
@@ -413,6 +413,7 @@ int set_direct_map_valid_noflush(struct page *page, unsigned nr, bool valid)
 
 	return __set_memory((unsigned long)page_to_virt(page), nr, flags);
 }
+EXPORT_SYMBOL_FOR_MODULES(set_direct_map_valid_noflush, "kvm");
 
 bool kernel_page_present(struct page *page)
 {
diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
index 8834c76f91c9..87e9c7d2dcdc 100644
--- a/arch/x86/mm/pat/set_memory.c
+++ b/arch/x86/mm/pat/set_memory.c
@@ -2661,6 +2661,7 @@ int set_direct_map_valid_noflush(struct page *page, unsigned nr, bool valid)
 
 	return __set_pages_np(page, nr);
 }
+EXPORT_SYMBOL_FOR_MODULES(set_direct_map_valid_noflush, "kvm");
 
 #ifdef CONFIG_DEBUG_PAGEALLOC
 void __kernel_map_pages(struct page *page, int numpages, int enable)
-- 
2.50.1


  parent reply	other threads:[~2025-08-28  9:39 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28  9:39 [PATCH v5 00/12] Direct Map Removal Support for guest_memfd Roy, Patrick
2025-08-28  9:39 ` [PATCH v5 01/12] filemap: Pass address_space mapping to ->free_folio() Roy, Patrick
2025-08-28  9:39 ` Roy, Patrick [this message]
2025-08-28 10:07   ` [PATCH v5 02/12] arch: export set_direct_map_valid_noflush to KVM module Fuad Tabba
2025-09-01 13:47     ` Roy, Patrick
2025-08-28  9:39 ` [PATCH v5 03/12] mm: introduce AS_NO_DIRECT_MAP Roy, Patrick
2025-08-28 10:21   ` Fuad Tabba
2025-09-01 13:54     ` Roy, Patrick
2025-09-01 14:56       ` Roy, Patrick
2025-09-02  7:59         ` Fuad Tabba
2025-09-02  8:46           ` David Hildenbrand
2025-09-02  8:50             ` Fuad Tabba
2025-09-02  9:18               ` Roy, Patrick
2025-09-02  9:21                 ` Fuad Tabba
2025-09-02  9:54                   ` David Hildenbrand
2025-08-28 14:26   ` Mike Rapoport
2025-09-01 13:56     ` Roy, Patrick
2025-08-28 21:00   ` David Hildenbrand
2025-09-01 14:03     ` Roy, Patrick
2025-08-31 10:26   ` kernel test robot
2025-09-01 14:05     ` Roy, Patrick
2025-08-28  9:39 ` [PATCH v5 04/12] KVM: guest_memfd: Add flag to remove from direct map Roy, Patrick
2025-08-28 14:54   ` Mike Rapoport
2025-09-01 14:22     ` Roy, Patrick
2025-09-01 14:27       ` Mike Rapoport
2025-08-28  9:39 ` [PATCH v5 05/12] KVM: Documentation: describe GUEST_MEMFD_FLAG_NO_DIRECT_MAP Roy, Patrick
2025-08-28 10:27   ` David Hildenbrand
2025-09-01 14:30     ` Roy, Patrick
2025-09-01 14:43       ` David Hildenbrand
2025-08-28  9:39 ` [PATCH v5 06/12] KVM: selftests: load elf via bounce buffer Roy, Patrick
2025-08-28  9:39 ` [PATCH v5 07/12] KVM: selftests: set KVM_MEM_GUEST_MEMFD in vm_mem_add() if guest_memfd != -1 Roy, Patrick
2025-08-28  9:39 ` [PATCH v5 08/12] KVM: selftests: Add guest_memfd based vm_mem_backing_src_types Roy, Patrick
2025-08-28  9:39 ` [PATCH v5 09/12] KVM: selftests: stuff vm_mem_backing_src_type into vm_shape Roy, Patrick
2025-08-28  9:39 ` [PATCH v5 10/12] KVM: selftests: cover GUEST_MEMFD_FLAG_NO_DIRECT_MAP in mem conversion tests Roy, Patrick
2025-08-28  9:39 ` [PATCH v5 11/12] KVM: selftests: cover GUEST_MEMFD_FLAG_NO_DIRECT_MAP in guest_memfd_test.c Roy, Patrick
2025-08-28 10:26   ` David Hildenbrand
2025-08-28  9:39 ` [PATCH v5 12/12] KVM: selftests: Test guest execution from direct map removed gmem Roy, Patrick
2025-08-28 12:50 ` [PATCH v5 00/12] Direct Map Removal Support for guest_memfd David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250828093902.2719-3-roypat@amazon.co.uk \
    --to=roypat@amazon.co.uk \
    --cc=ackerleytng@google.com \
    --cc=david@redhat.com \
    --cc=derekmn@amazon.com \
    --cc=jackabt@amazon.co.uk \
    --cc=kalyazin@amazon.co.uk \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pbonzini@redhat.com \
    --cc=rppt@kernel.org \
    --cc=seanjc@google.com \
    --cc=tabba@google.com \
    --cc=vbabka@suse.cz \
    --cc=will@kernel.org \
    --cc=xmarcalx@amazon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox