From: Nathan Chancellor <nathan@kernel.org>
To: Oliver Upton <oupton@kernel.org>
Cc: kvmarm@lists.linux.dev, Marc Zyngier <maz@kernel.org>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Subject: Re: [PATCH 1/2] KVM: arm64: Drop useless __GFP_HIGHMEM from kvm struct allocation
Date: Thu, 20 Nov 2025 00:08:48 -0700 [thread overview]
Message-ID: <20251120070848.GA1879143@ax162> (raw)
In-Reply-To: <20251119093822.2513142-2-oupton@kernel.org>
On Wed, Nov 19, 2025 at 01:38:21AM -0800, Oliver Upton wrote:
> A recent change on the receiving end of vmalloc() started warning about
> unsupported GFP flags passed by the caller. Nathan reports that this
> warning fires in kvm_arch_alloc_vm(), owing to the fact that KVM is
> passing a meaningless __GFP_HIGHMEM.
>
> Do as the warning says and fix the code.
>
> Cc: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Closes: https://lore.kernel.org/kvmarm/20251118224448.GA998046@ax162/
> Signed-off-by: Oliver Upton <oupton@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Thanks for the patch!
> ---
> arch/arm64/kvm/arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index 870953b4a8a7..e791fa52f874 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -440,7 +440,7 @@ struct kvm *kvm_arch_alloc_vm(void)
> if (!has_vhe())
> return kzalloc(sz, GFP_KERNEL_ACCOUNT);
>
> - return __vmalloc(sz, GFP_KERNEL_ACCOUNT | __GFP_HIGHMEM | __GFP_ZERO);
> + return __vmalloc(sz, GFP_KERNEL_ACCOUNT | __GFP_ZERO);
> }
>
> int kvm_arch_vcpu_precreate(struct kvm *kvm, unsigned int id)
> --
> 2.47.3
>
next prev parent reply other threads:[~2025-11-20 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 9:38 [PATCH 0/2] KVM: arm64: Fixes to KVM struct allocation Oliver Upton
2025-11-19 9:38 ` [PATCH 1/2] KVM: arm64: Drop useless __GFP_HIGHMEM from kvm " Oliver Upton
2025-11-20 7:08 ` Nathan Chancellor [this message]
2025-11-19 9:38 ` [PATCH 2/2] KVM: arm64: Use kvzalloc() for " Oliver Upton
2025-11-19 10:32 ` [PATCH 0/2] KVM: arm64: Fixes to KVM " Joey Gouly
2025-11-19 13:08 ` Marc Zyngier
2025-11-19 19:12 ` Vishal Moola (Oracle)
2025-11-19 22:35 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120070848.GA1879143@ax162 \
--to=nathan@kernel.org \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=vishal.moola@gmail.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox