From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 231C42E0418 for ; Thu, 27 Nov 2025 10:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764240070; cv=none; b=lvCZrcATRElHD4vuq+ErEBwHcVGJLnjkUBIOJsYt7mC+qotFGT+2g1lTGgRERG3qjP2Vx1RK4OD3v1sQM8Mf06P9qhj+7L9y4kwADD+yBP2bCUGw2GOTIetfdYe4PWaEkeUwUlR8UsDjecB2I0NXkKvjsf2y+PHXXXwg+vlhHeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764240070; c=relaxed/simple; bh=L8S7X2ILcrEGd7YmC0JEf3ASiZy8DsNlBWR/cTWH2ro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=edkRpTnY00kx9GSAX0Ejfn5w9iJnZJWDxUTiRK86IoFsdERYjRtEQRWJ7M6mQJQykbYnjGZZTqe+dEwy9C2pwCKq+qe6578XQQBwKvy4ZItC+ZkgabBorZlhaw1adPHY1+UZmc9E2YxOJcZEiYhkZbiLoHKJVdSX7ZFDTwSYQ/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 074D81477; Thu, 27 Nov 2025 02:40:59 -0800 (PST) Received: from e124191.cambridge.arm.com (e124191.cambridge.arm.com [10.1.197.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 313993F6A8; Thu, 27 Nov 2025 02:41:05 -0800 (PST) Date: Thu, 27 Nov 2025 10:40:59 +0000 From: Joey Gouly To: Eric Auger Cc: kvm@vger.kernel.org, alexandru.elisei@arm.com, andrew.jones@linux.dev, kvmarm@lists.linux.dev, Marc Zyngier , Oliver Upton Subject: Re: [kvm-unit-tests PATCH v3 10/10] arm64: add EL2 environment variable Message-ID: <20251127104059.GA3237269@e124191.cambridge.arm.com> References: <20250925141958.468311-1-joey.gouly@arm.com> <20250925141958.468311-11-joey.gouly@arm.com> <6e735f02-dbd6-4807-95b3-4043049d4557@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e735f02-dbd6-4807-95b3-4043049d4557@redhat.com> On Thu, Nov 27, 2025 at 11:34:56AM +0100, Eric Auger wrote: > Hi Joey, > > On 9/25/25 4:19 PM, Joey Gouly wrote: > > This variable when set to 1 will cause QEMU/kvmtool to start at EL2. > > Misses the Sob. If this counts: Signed-off-by: Joey Gouly I have fixed kvm-unit-tests to add that automatically to my commits now, thanks. > > Besides Reviewed-by: Eric Auger Thanks, Joey > > Eric > > > --- > > arm/run | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arm/run b/arm/run > > index 858333fc..2a9c0de0 100755 > > --- a/arm/run > > +++ b/arm/run > > @@ -59,6 +59,10 @@ function arch_run_qemu() > > M+=",highmem=off" > > fi > > > > + if [ "$EL2" = "1" ]; then > > + M+=",virtualization=on" > > + fi > > + > > if ! $qemu $M -device '?' | grep -q virtconsole; then > > echo "$qemu doesn't support virtio-console for chr-testdev. Exiting." > > exit 2 > > @@ -116,6 +120,9 @@ function arch_run_kvmtool() > > fi > > > > command="$(timeout_cmd) $kvmtool run" > > + if [ "$EL2" = "1" ]; then > > + command+=" --nested" > > + fi > > if [ "$HOST" = "aarch64" ] && [ "$ARCH" = "arm" ]; then > > run_test_status $command --kernel "$@" --aarch32 > > else >