From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9AD652DA758 for ; Thu, 4 Dec 2025 10:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764844329; cv=none; b=ATy4DKF8l2NxjWE1dlKAhZYM5Me/y6wgwYk1lBMzSX4TWfQlx5z1VCOIqAL2zHe74kwAlDtO5tHawkrYXtjT9vlEmruzK/3/Z9+itfeK3UMTmsSSGUKZb3uaitHFxhC+O+tuz6mlUq5l4WZDNrIWdyQSuiV9DFQl0sRBSfnyvq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764844329; c=relaxed/simple; bh=QwUIPIBLm9OAA0qqJ/xUY6DKTZhxaRq/wQV3yV8DIS0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oM38DqF7b45lX7VTkmfElVheDRSYT60ix6afWik9wjyPu8OxFYPJvZYwzGO1IsqgqRamAVrs1mMZ8lA+ewxpNRlOkd6MwrAzBmYbAuVfGjTziPDTcLGHTlEq2/9Q8NduucTjeORGZslbkZOIS6wnsa2COx/tSDbXQIgo7qzicac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79FB2339; Thu, 4 Dec 2025 02:32:00 -0800 (PST) Received: from e124191.cambridge.arm.com (e124191.cambridge.arm.com [10.1.197.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4010A3F73B; Thu, 4 Dec 2025 02:32:06 -0800 (PST) Date: Thu, 4 Dec 2025 10:32:00 +0000 From: Joey Gouly To: Marc Zyngier Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Suzuki K Poulose , Oliver Upton , Zenghui Yu , Ben Horgan , Yao Yuan Subject: Re: [PATCH v3 1/9] arm64: Repaint ID_AA64MMFR2_EL1.IDS description Message-ID: <20251204103200.GA98666@e124191.cambridge.arm.com> References: <20251204094806.3846619-1-maz@kernel.org> <20251204094806.3846619-2-maz@kernel.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204094806.3846619-2-maz@kernel.org> On Thu, Dec 04, 2025 at 09:47:58AM +0000, Marc Zyngier wrote: > ID_AA64MMFR2_EL1.IDS, as described in the sysreg file, is pretty horrible > as it diesctly give the ESR value. Repaint it using the usual NI/IMP typo: directly > identifiers to describe the absence/presence of FEAT_IDST. > > Signed-off-by: Marc Zyngier Reviewed-by: Joey Gouly > --- > arch/arm64/kvm/hyp/nvhe/sys_regs.c | 2 +- > arch/arm64/tools/sysreg | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/sys_regs.c b/arch/arm64/kvm/hyp/nvhe/sys_regs.c > index 82da9b03692d4..107d62921b168 100644 > --- a/arch/arm64/kvm/hyp/nvhe/sys_regs.c > +++ b/arch/arm64/kvm/hyp/nvhe/sys_regs.c > @@ -134,7 +134,7 @@ static const struct pvm_ftr_bits pvmid_aa64mmfr2[] = { > MAX_FEAT(ID_AA64MMFR2_EL1, UAO, IMP), > MAX_FEAT(ID_AA64MMFR2_EL1, IESB, IMP), > MAX_FEAT(ID_AA64MMFR2_EL1, AT, IMP), > - MAX_FEAT_ENUM(ID_AA64MMFR2_EL1, IDS, 0x18), > + MAX_FEAT_ENUM(ID_AA64MMFR2_EL1, IDS, IMP), > MAX_FEAT(ID_AA64MMFR2_EL1, TTL, IMP), > MAX_FEAT(ID_AA64MMFR2_EL1, BBM, 2), > MAX_FEAT(ID_AA64MMFR2_EL1, E0PD, IMP), > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index 1c6cdf9d54bba..3261e8791ac03 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -2257,8 +2257,8 @@ UnsignedEnum 43:40 FWB > 0b0001 IMP > EndEnum > Enum 39:36 IDS > - 0b0000 0x0 > - 0b0001 0x18 > + 0b0000 NI > + 0b0001 IMP > EndEnum > UnsignedEnum 35:32 AT > 0b0000 NI > -- > 2.47.3 >