From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA1632D0C62 for ; Mon, 22 Dec 2025 18:06:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766426792; cv=none; b=HBg6sR0elTCHDgqwXML0ZhOjNHjgPHN4GONp/H22cLnItEA/zQUXCWwqA+OM5oJ1gvqNEeNeNmtB4b+pDuewd+gZzlVoT/HORhJcTImyxiD3j5ExcUqQmPvlcMH/HFi5KjkBESFvLmFUr821zQb9GFPWSwehA/Rqd9A9hP5C6Y4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766426792; c=relaxed/simple; bh=CQsSsbliIcyPp1VRQTPFQdTLRH4YhJiBswXOEthVJ08=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FNa7AJ5GWlc0k9AD9GNZMEGb4ZCsGKDhCUHG6ZRfewYS2EBEhnYn7JrrrDsmappKACoW74C0sZpApd8SysGGLo/mATQT+tptcX5CfqjXxlsk/ru3tkcLFBN3hrUeZfjzY3LAwHr+huuoMNI2h2Mt39MDR+g0O0ijdmRxNub+hPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=avw/BcKo; arc=none smtp.client-ip=91.218.175.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="avw/BcKo" Date: Mon, 22 Dec 2025 12:06:08 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766426783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MD+k29yEgQqQtWq7yJ0+IwowUibiEOtC9WU2KKaDscU=; b=avw/BcKo42R+Ay4EEthtfmeZ5W8JefBuR0FojzfVz4LpGT247fjXQLe7L3LrLKsODAQ3Ao AvutCZfCqhp/OCF0ebVQ24Zc+1yluTlQy3ouO+TFGicMFff+odeWFMgp1+ngK91lfcm6Po WojIATe0n94SDnECoCuCJIYPrl9g6FE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Fuad Tabba Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, pbonzini@redhat.com, shuah@kernel.org, anup@brainfault.org Subject: Re: [PATCH v2 2/5] KVM: arm64: selftests: Fix incorrect rounding in page_align() Message-ID: <20251222-f8d98d81659c01f79e16da2f@orel> References: <20251215165155.3451819-1-tabba@google.com> <20251215165155.3451819-3-tabba@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251215165155.3451819-3-tabba@google.com> X-Migadu-Flow: FLOW_OUT On Mon, Dec 15, 2025 at 04:51:52PM +0000, Fuad Tabba wrote: > The implementation of `page_align()` in `processor.c` calculates > alignment incorrectly for values that are already aligned. Specifically, > `(v + vm->page_size) & ~(vm->page_size - 1)` aligns to the *next* page > boundary even if `v` is already page-aligned, potentially wasting a page > of memory. > > Fix the calculation to use standard alignment logic: `(v + vm->page_size > - 1) & ~(vm->page_size - 1)`. > > Fixes: 7a6629ef746d ("kvm: selftests: add virt mem support for aarch64") > Signed-off-by: Fuad Tabba > --- > tools/testing/selftests/kvm/lib/arm64/processor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/lib/arm64/processor.c b/tools/testing/selftests/kvm/lib/arm64/processor.c > index 5b379da8cb90..607a4e462984 100644 > --- a/tools/testing/selftests/kvm/lib/arm64/processor.c > +++ b/tools/testing/selftests/kvm/lib/arm64/processor.c > @@ -23,7 +23,7 @@ static vm_vaddr_t exception_handlers; > > static uint64_t page_align(struct kvm_vm *vm, uint64_t v) > { > - return (v + vm->page_size) & ~(vm->page_size - 1); > + return (v + vm->page_size - 1) & ~(vm->page_size - 1); > } > > static uint64_t pgd_index(struct kvm_vm *vm, vm_vaddr_t gva) > -- > 2.52.0.239.gd5f0c6e74e-goog > > Thanks for finding and fixing this. I'll get my paper bag out later. Reviewed-by: Andrew Jones