From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FCE0221FCF for ; Tue, 30 Dec 2025 23:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767135716; cv=none; b=KYay5taYLYpeXZ0v2jcuCbjYhpOnt16kIcce5fWp16zesCJ8jdAMQ4D0ltN7paWRs04oGzWKBMweu9rN7BMWCqqBX9dr+iyhlW8b0nmw5S4GWeYFPhI7pjNLHYC/wYjV+1Ku2g/ii6Sh6fSsLnutGM67qentxsjwqUt4X9bitjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767135716; c=relaxed/simple; bh=Kx/fiK6tmrPIcA1iG4moF7Z6llpjtEf+Pn2+HnOib1o=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=idT1LnTtspkVhTq/OFLzyIdKUmO0QLzVE8LY0FxnQ3iqJyL9SqXNBG6fjWJrt++jpTx9CQmhQeIghBeGyiXBW7fIAGzMplamfvdfkYGeWG+eKanSIh70sa5ow460q0giN7fyJMrJkYPSAbOj7nurUfEqVcK5quQ82mjhogyn9r8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SMy438cV; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SMy438cV" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-7b80de683efso19262871b3a.3 for ; Tue, 30 Dec 2025 15:01:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1767135713; x=1767740513; darn=lists.linux.dev; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=DduiMfmTpcy5dWbJfJJBZV4wRgqp4T0woAtqbJ6bKWQ=; b=SMy438cV1UiQDQsT54yhIbj5Iw8KiFFfR7wO/J+pWknBu3UzsoY7fsoqE+0H3ogS8w ziLwfwbKtANVxSLPneN7BPk9wmFCKu7aR5mvJmOyJo8DZ0H90KNuIe1Ay/QkYWSwXAGs rRru6lMBCUw1FJmPY7KHTIXuQB+1tRLBgkXUinaAvk9ZgbeWBzqcQJyE6bOb2TOQyroU OXwI0RT+e5p6jn/G9Y1jpmzU6ifBGr9zYktlfqtEFAe9qHXxzt8X21rzEbR+jOO4imeQ JgCphUYUKobMeSFdd9xqzN53K/xFWl3w7VYqxoEA8BW/FTBVdlVWd5+eM481IYsScqNQ KiMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767135713; x=1767740513; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DduiMfmTpcy5dWbJfJJBZV4wRgqp4T0woAtqbJ6bKWQ=; b=A4v1RXfbYHIQ2SUWePmVWsQynRNV6LtiaZFd4hT7+U13vv1pPQXLmgOeJ3+O5d7Kn6 oNHyL4tt9Z79UKec305LxyhiyBBvzHP7wMZ2Y0m9MwWFKvY49yNSUQ8hyZr1X6FTBmja cAcW0m/NsYl+5uQ03kjV2B1euD5bwnnr6Y+QGvZxQpO+Xl04sPDPr3NYu2TLEaHMBS5k oFBiD0CzOuMELqKVIH3XGbYi4qsPpL3t5wxI9yvUL7+UaxsluM4NMKf0yE3z+jEtAdRf wPGt6N5Kl4QmFqnkwYeXvO9sBaY+diY42KyjQgI4huFO7/jUNxSMUwy4yBrVvfAtovov WeYA== X-Forwarded-Encrypted: i=1; AJvYcCVEG5604T2Ibyibq9ylMA/Znw8cbgEK82UNksU3ECPha05Cw79o5PcEhXp6QU1ZgVIVlOBS/ls=@lists.linux.dev X-Gm-Message-State: AOJu0YyBmW8j08xdzfB0Xe+896lfZvUoLL0Q9ii8Z/WB/48F3WUR1K8v TtnChS3nCXmZq254OXN4I3uT3VLHDnS/Nb7CFGp0EqEVpIRLIcZeKaQ82z72yuNfHGz6Vrf11z+ Iw3qMXw== X-Google-Smtp-Source: AGHT+IFl5YLLzZS88Mfh7NFRVwFsdWY7dXmSPWiNHP66M1DsoJkgDWwQHxi6m97nCMs9lyQggVclX+5VgK0= X-Received: from pjbge24.prod.google.com ([2002:a17:90b:e18:b0:34c:cb46:dad7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:e083:b0:361:3bec:fe28 with SMTP id adf61e73a8af0-376a9de5b35mr35584887637.37.1767135712714; Tue, 30 Dec 2025 15:01:52 -0800 (PST) Reply-To: Sean Christopherson Date: Tue, 30 Dec 2025 15:01:29 -0800 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.351.gbe84eed79e-goog Message-ID: <20251230230150.4150236-1-seanjc@google.com> Subject: [PATCH v4 00/21] KVM: selftests: Add Nested NPT support From: Sean Christopherson To: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Yosry Ahmed Content-Type: text/plain; charset="UTF-8" Yosry's series to add support for nested NPT, and extends vmx_dirty_log_test and kvm_dirty_log_test (with -n, using memstress) to cover nested SVM. Note, I'm mildly concerned the last patch to extend nested_dirty_log_test to validate KVM's handling of READ faults could be flaky, e.g. maybe if someone is running the test under heavy memory pressure and the to-be-access page is swapped between the write-from-host and read-from-guest? But unless someone knows/shows it'll be flaky, I'm inclined to apply it and hope for the best. v4: - Document the likely reason for setting A/D bits. - Put "mmu" structure in common "struct kvm". - Make it clear PTE accessors are predicates. - Assert that the stage-2 MMU is initialized at most once. - Make READABLE a standalone bit (don't overload USER). - Don't alias PRESENT => READABLE for EPT. - Fix the A/D bit definitions for EPT. - Drop the function comment for __tdp_map(). - Add a patch to extend the nested_dirty_log_test to verify that KVM creates writable SPTEs when the gPTEs are writable and dirty. v3: - https://lore.kernel.org/all/20251127013440.3324671-1-yosry.ahmed@linux.dev - Dropped the patches that landed in kvm-x86. - Reshuffled some patches and cleanups. - Introduced kvm_mmu data structures to hold the root, page table levels, and page table masks (Sean). - Extended memstress as well to cover nested SVM. v2: https://lore.kernel.org/kvm/20251021074736.1324328-1-yosry.ahmed@linux.dev Sean Christopherson (7): KVM: selftests: Add "struct kvm_mmu" to track a given MMU instance KVM: selftests: Plumb "struct kvm_mmu" into x86's MMU APIs KVM: selftests: Add a "struct kvm_mmu_arch arch" member to kvm_mmu KVM: selftests: Add a stage-2 MMU instance to kvm_vm KVM: selftests: Move TDP mapping functions outside of vmx.c KVM: selftests: Rename vm_get_page_table_entry() to vm_get_pte() KVM: selftests: Test READ=>WRITE dirty logging behavior for shadow MMU Yosry Ahmed (14): KVM: selftests: Make __vm_get_page_table_entry() static KVM: selftests: Stop passing a memslot to nested_map_memslot() KVM: selftests: Rename nested TDP mapping functions KVM: selftests: Kill eptPageTablePointer KVM: selftests: Stop setting A/D bits when creating EPT PTEs KVM: selftests: Move PTE bitmasks to kvm_mmu KVM: selftests: Use a TDP MMU to share EPT page tables between vCPUs KVM: selftests: Stop passing VMX metadata to TDP mapping functions KVM: selftests: Reuse virt mapping functions for nested EPTs KVM: selftests: Allow kvm_cpu_has_ept() to be called on AMD CPUs KVM: selftests: Add support for nested NPTs KVM: selftests: Set the user bit on nested NPT PTEs KVM: selftests: Extend vmx_dirty_log_test to cover SVM KVM: selftests: Extend memstress to run on nested SVM tools/testing/selftests/kvm/Makefile.kvm | 2 +- .../kvm/include/arm64/kvm_util_arch.h | 2 + .../testing/selftests/kvm/include/kvm_util.h | 18 +- .../kvm/include/loongarch/kvm_util_arch.h | 1 + .../kvm/include/riscv/kvm_util_arch.h | 1 + .../kvm/include/s390/kvm_util_arch.h | 1 + .../selftests/kvm/include/x86/kvm_util_arch.h | 22 ++ .../selftests/kvm/include/x86/processor.h | 58 +++- .../selftests/kvm/include/x86/svm_util.h | 9 + tools/testing/selftests/kvm/include/x86/vmx.h | 16 +- .../selftests/kvm/lib/arm64/processor.c | 38 +-- tools/testing/selftests/kvm/lib/kvm_util.c | 28 +- .../selftests/kvm/lib/loongarch/processor.c | 28 +- .../selftests/kvm/lib/riscv/processor.c | 31 ++- .../selftests/kvm/lib/s390/processor.c | 16 +- .../testing/selftests/kvm/lib/x86/memstress.c | 66 +++-- .../testing/selftests/kvm/lib/x86/processor.c | 237 ++++++++++++---- tools/testing/selftests/kvm/lib/x86/svm.c | 24 ++ tools/testing/selftests/kvm/lib/x86/vmx.c | 251 ++++------------- .../selftests/kvm/x86/hyperv_tlb_flush.c | 2 +- .../selftests/kvm/x86/nested_dirty_log_test.c | 259 ++++++++++++++++++ .../x86/smaller_maxphyaddr_emulation_test.c | 4 +- .../selftests/kvm/x86/vmx_dirty_log_test.c | 179 ------------ .../kvm/x86/vmx_nested_la57_state_test.c | 2 +- 24 files changed, 726 insertions(+), 569 deletions(-) create mode 100644 tools/testing/selftests/kvm/x86/nested_dirty_log_test.c delete mode 100644 tools/testing/selftests/kvm/x86/vmx_dirty_log_test.c base-commit: 9448598b22c50c8a5bb77a9103e2d49f134c9578 -- 2.52.0.351.gbe84eed79e-goog