Re: [PATCH v5 4/8] KVM: arm64: Move PSCI helper functions to a shared header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The header `include/kvm/arm_psci.h` uses architecture-specific functions (`vcpu_get_reg`, `vcpu_set_reg`) without including the necessary header `<asm/kvm_emulate.h>`, breaking header self-containment.
--

--- Patch [4]: [PATCH v5 4/8] KVM: arm64: Move PSCI helper functions to a shared header ---
Note: The format of this report has been altered due to recitation restrictions. The original patch code is not quoted directly.

commit 0c74ab23a0a20b7f1a788c6ac3e03217bd5099cd
Author: Fuad Tabba <fuad.tabba@linux.dev>

KVM: arm64: Move PSCI helper functions to a shared header

This commit moves several PSCI helper functions out of arch/arm64/kvm/psci.c
and into the shared include/kvm/arm_psci.h header. This allows the functions
to be reused, specifically for a follow-up series that handles protected-guest
PSCI calls at EL2.

[Severity: Low]
Does include/kvm/arm_psci.h need to explicitly include <asm/kvm_emulate.h>?

Looking at the moved inline function kvm_psci_narrow_to_32bit(), it relies
on vcpu_get_reg() and vcpu_set_reg(). These functions are provided by
<asm/kvm_emulate.h>, but that header does not appear to be included in 
include/kvm/arm_psci.h.

Will this cause build failures if a new compilation unit (such as the EL2 
pKVM follow-up series mentioned in the commit message) includes 
<kvm/arm_psci.h> directly without having already included <asm/kvm_emulate.h>?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714101601.4142645-1-fuad.tabba@linux.dev?part=4