Re: [PATCH v4 03/11] KVM: Export kvm_uevent_notify_vm_create()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch claims to export `kvm_uevent_notify_vm_create()` but fails to include the `EXPORT_SYMBOL_GPL()` or `EXPORT_SYMBOL_FOR_KVM_INTERNAL()` macro.
--

--- Patch [3]: [PATCH v4 03/11] KVM: Export kvm_uevent_notify_vm_create() ---
commit 5e642ea16f0d267e622a352de60bfe397ecf79df
Author: Tarun Sahu <tarunsahu@google.com>

KVM: Export kvm_uevent_notify_vm_create()

This commit exposes the kvm_uevent_notify_vm_create function to allow
triggering KVM event notifications during VM creation.

[ ... ]

> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -6348,6 +6348,11 @@ static void kvm_uevent_notify_change(unsigned int type, struct kvm *kvm)
>  	kfree(env);
>  }
>  
> +void kvm_uevent_notify_vm_create(struct kvm *kvm)
> +{
> +	kvm_uevent_notify_change(KVM_EVENT_CREATE_VM, kvm);
> +}

[Severity: Low]
The commit message mentions exporting this function, but is it missing an
EXPORT_SYMBOL_GPL or EXPORT_SYMBOL_FOR_KVM_INTERNAL declaration?

Without the macro, won't dynamically loaded architecture-specific modules
like kvm-intel.ko hit undefined symbol linking errors when they try to
call it?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728121138.1103610-1-tarunsahu@google.com?part=3