From: Fuad Tabba <fuad.tabba@linux.dev>
To: Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@kernel.org>
Cc: Eric Auger <eauger@redhat.com>, Joey Gouly <joey.gouly@arm.com>,
Steffen Eiden <seiden@linux.ibm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>, Will Deacon <will@kernel.org>,
Sascha Bischoff <sascha.bischoff@arm.com>,
Sebastian Ene <sebastianene@google.com>,
Fuad Tabba <tabba@google.com>,
kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] KVM: arm64: vgic-its: Reword the comment on a collection-less ITE
Date: Mon, 17 Aug 2026 10:27:05 +0100 [thread overview]
Message-ID: <20260817092705.1112634-1-fuad.tabba@linux.dev> (raw)
The comment above the NULL collection check in vgic_its_save_ite()
names only MAPC with V=0, which is UNPREDICTABLE. The route that
requires the check is clearing GITS_BASER<coll>.Valid on a disabled
ITS, a legitimate operation that orphans every ITE at once. Name both
routes.
No functional change intended.
Suggested-by: Eric Auger <eauger@redhat.com>
Link: https://lore.kernel.org/all/0ce5e496-a067-48fd-80d2-94fe9981d505@redhat.com/
Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
---
Notes:
Based on kvmarm/next, since the comment this reworks was added by
c6c156d931c3 ("KVM: arm64: vgic-its: Don't dereference a NULL collection
on ITT save") and is not in a release yet.
arch/arm64/kvm/vgic/vgic-its.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c
index f6538b1976f9b..26c665e0a2386 100644
--- a/arch/arm64/kvm/vgic/vgic-its.c
+++ b/arch/arm64/kvm/vgic/vgic-its.c
@@ -2112,9 +2112,9 @@ static int vgic_its_save_ite(struct vgic_its *its, struct its_device *dev,
u64 val;
/*
- * MAPC with V=0 keeps the ITEs mapped but drops their collection,
- * and with it the ICID. Save a zeroed entry, which the restore path
- * reads back as invalid.
+ * MAPC with V=0 and clearing GITS_BASER<coll>.Valid both keep the
+ * ITEs mapped while dropping their collection, and with it the ICID.
+ * Save a zeroed entry, which the restore path reads back as invalid.
*/
if (!ite->collection)
return vgic_its_write_entry_lock(its, gpa, 0ULL, ite);
base-commit: 57e7cf13ac26bf1a3dba6cfa601f7b2481811575
--
2.39.5
next reply other threads:[~2026-08-17 9:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 9:27 Fuad Tabba [this message]
2026-08-17 9:40 ` [PATCH] KVM: arm64: vgic-its: Reword the comment on a collection-less ITE Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817092705.1112634-1-fuad.tabba@linux.dev \
--to=fuad.tabba@linux.dev \
--cc=eauger@redhat.com \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=sascha.bischoff@arm.com \
--cc=sebastianene@google.com \
--cc=seiden@linux.ibm.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox