Re: [PATCH 13/20] KVM: selftests: Add TEST_EXTRA memory region type for "special" memslots

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added documentation comment for `enum kvm_mem_region_type` incorrectly states that all regions are mapped to memslot '0' by default. This is false for the new `MEM_REGION_TEST_EXTRA` type.
--

commit 80ca587b6992ae5dadcd1c12481741cde386a790
Author: Sean Christopherson <seanjc@google.com>

KVM: selftests: Add TEST_EXTRA memory region type for "special" memslots

This commit introduces a new MEM_REGION_TEST_EXTRA memory region type for
managing one-off extra memslots, such as x86's SMRAM memslot. It also adds
documentation comments explaining the intended usage of each memory region
type.

> diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h
> index 14f87c8a00ec6..f4f4f360a10b7 100644
> --- a/tools/testing/selftests/kvm/include/kvm_util.h
> +++ b/tools/testing/selftests/kvm/include/kvm_util.h
> @@ -82,11 +82,43 @@ struct userspace_mem_regions {
>  	DECLARE_HASHTABLE(slot_hash, 9);
>  };
>  
> +/*
> + * Memory region types are passed to various page allocators to communicate
> + * various properties and metadata related to the allocation.  Note, the
> + * descriptions below described the primary usage of each type.  Individual
> + * tests may allocate memory for other purposes.
> + *
> + * By default, all regions are mapped to memslot '0'.  Tests can override the
> + * memslot for any or all types, e.g. so that all test data is allocated from a
> + * curated memslot.
> + */
>  enum kvm_mem_region_type {

[Severity: Low]
Does this comment accurately reflect the behavior of the newly added
MEM_REGION_TEST_EXTRA type?

It appears that MEM_REGION_TEST_EXTRA is left unmapped by default (initialized
to KVM_INVALID_MEMSLOT in ____vm_create()) rather than mapped to memslot '0'.
This allows it to be safely overridden later without triggering the assertion
in ____vm_override_mem_region().

Could this documentation be misleading for developers writing new tests who
might assume MEM_REGION_TEST_EXTRA has a valid fallback memslot and try to
use it without explicitly overriding it first?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826230511.972824-1-seanjc@google.com?part=13