From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88F023C0630 for ; Mon, 21 Sep 2026 21:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790026645; cv=none; b=H0bbW7HVS15WO87ZZhTvyxX+kqEWZDQS7DQm+S9GX1zqGIg7XEKTmyHugDjNDb4wt8WqKBrBeEXnYMtFqllqixSN/c/GGPFtYXAWp+iyZEPDRaVUZiKhUGS5B6ffb5/3zZVcLqStZ7MXvgh56Arad46EQDDb+F2rECfNPiXryGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790026645; c=relaxed/simple; bh=5Ts24efOpui+13n7/Xsa/KfOpnWj+hW11Ewp1k0kAwI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=E41N9QLjr1Xl1JtyxdllSfX3CnXTORf9TUU5AF4uC9gEtz5lK1cevnWwpgAtEdIGZLwdvbvu9QqTkLw9feByhzobwbbiVCOwTDrlnSU+ejgPjJVpC2vEKYZMyn0R7xjtHsTuYdFAkMIcfgDY9hE4FK0LG1ooM8S1NfKAuAZeLUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=crwk3eZF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZVY2aALH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="crwk3eZF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZVY2aALH" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68LKeCuC3423863 for ; Mon, 21 Sep 2026 21:37:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Swt0YNhB50FD81oDu+eeGBpzGMZ5gYqJP471jCzHYIk=; b=crwk3eZFEJnuHuwA BxX1kqi8xITwzyLEXrOfDs9Hftiy1udNkfXh1s9EoS9FDMi9SYYra2hr/LwQMuPH kMlwgDt70V9cANFNiAuf4sNIShxrP2xTz7dV0eAMRZIBCBHgh5tKnigxbVhBm4iv W4t9IZd3gJA551FAz5yi2qOckuGgI9N3N8h5rUFAgWenLb8pVjTLmbX8XBA8qRSS xpy2rNyF96OUBBEDD9WZwHg9nbH/k4P0xWLhfXzD/R/hQsoN135rLUS111W5+VpF RkOszKlROCP7sxheX72VT4GUcGfsSaHovQBWU5lbEoVK1R1uUT6LNq+Ulg9qLZ73 sZCHpg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gu8v50xne-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 21 Sep 2026 21:37:23 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2d94a158dc8so61256645ad.2 for ; Mon, 21 Sep 2026 14:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790026643; x=1790631443; darn=lists.linux.dev; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Swt0YNhB50FD81oDu+eeGBpzGMZ5gYqJP471jCzHYIk=; b=ZVY2aALHaUooh8QHIuWmITZzzOabCQ3TuQnI1cGv5axsjkBEhDxEEM7Zvo7dkhknhs ypnfgBekmZDMBVtR3RrMd6le1/GW+rYy3tKu+AjNE+VlwSJzyQZFWSvj+lg6aA51gOAC 35vzHj6BFr90CEGn72RaTAlJuY+bIQOPZVGl47ln9MG4FqwnYvmX+RwOsw0hKYuYwk4Z cSQEVNzlZJT/YSW5sY0LUHvZdf82bq7gJi4MA7cybwrAYnaw/k99fuzHTotXHJUMMynz cip/yfc+M7kmrIfaNPI+Pi7CvC+6zpU/WBTC7lLUJn6Fig8xP+v463o+2nvLz9zs6tKO RsuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790026643; x=1790631443; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Swt0YNhB50FD81oDu+eeGBpzGMZ5gYqJP471jCzHYIk=; b=BoRQfNZDscGYt8C1n2eUcoRFbk9j+LtgUhzlosqGVbgwCPOkCTFbEWLmK4EXOdjndo 3UCbSUADfOyUACHcsdS7Ty4Ny5sGIbyFV4M1kLN/IuN0hj4QgMAim71b3m6gnpqfQW9U NKBoB5aAP4q0TJtB/HETzCaj8E3bH33bHMIkoS0NbvwSM6xUwG2SGsFUDNS9Ndbij4OK iEuDKWhPOC5y1kS3uLRerh5uK24uUpulVq/eTwxEXraj95yGexhzukX0qE34ieOhNMIv xZbAvY9TtP/Uz0GGmDjdxLOl4cDxiCUPRpWSTcsGQ2kPE02/GIMBuEAy7JWT2AOTA4Uw FNiw== X-Forwarded-Encrypted: i=1; AKwUvBylnT7LEFg5LzNJWQ+FJ8tjbc+yogxVN/hDGRd0vPCKnLaXWDIWxkb1DhlkJ8EqAivCc87IAVA=@lists.linux.dev X-Gm-Message-State: AFuF++kCRkdORLhB2cVE5B3lEZ22NiVDUvEmLVUe8qhAL2LP7NR7zQWi tsam79q8GyajrZnHC0tF3kTi/RksW7ugBQATu/sHaBSDcpli0sVx+Kmt6MVCCKdIbhA3uzb+M61 SaKrN8oCvZVZGYewnX9ltwpAKAG5nqOxQ5NvVCsdYGoNfrfMV4tnqWckLMLE= X-Gm-Gg: AYBFou2uSDMsySDxuu+mwFDPWKeh5yC2FxyX5UqJizCrhjgpExKV5ojeFzGcxgah1Li KyjvzPYhXithh3zbYcGxQqB91RIAeBh1WMpGuG9M+d/4qgXoYzf3/zVw6kjtnVtQYaYwG7w0Mua pMboGQHUJCQ3oeWtGp1XO0MXB3Mo1AZ61u7YShGEzX8yIPcZNIJVZSF2ZkHs8EElhZaLtXcg2qQ CN/NZrXzmNrykN19sKA8yB/hZpxU+PvBScPzj+gcvxYcIKBxAynkV/DYJ74I2YGq+N+Al2EtUIf rlUxjANUct8X1zkbNV/snPI7M6TlucUshwTfhcGaruFDu8oSnRjMAsyb7ERgdEeaUX6aVGN5/bF OKhHlRE6kU9HMssQD1HjIIdGd3g== X-Received: by 2002:a17:902:ebc6:b0:2dd:c053:9c6e with SMTP id d9443c01a7336-2ddc0539da7mr117471815ad.36.1790026643042; Mon, 21 Sep 2026 14:37:23 -0700 (PDT) X-Received: by 2002:a17:902:ebc6:b0:2dd:c053:9c6e with SMTP id d9443c01a7336-2ddc0539da7mr117471595ad.36.1790026642576; Mon, 21 Sep 2026 14:37:22 -0700 (PDT) Received: from localhost ([50.35.44.179]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33e5ec0d55esm650212eec.20.2026.09.21.14.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 14:37:22 -0700 (PDT) Date: Mon, 21 Sep 2026 14:37:18 -0700 From: Jonathan Cameron To: Suzuki K Poulose Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, maz@kernel.org, will@kernel.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, steven.price@arm.com, aneesh.kumar@kernel.org, oupton@kernel.org, gshan@redhat.com, joey.gouly@arm.com, tabba@google.com, yuzenghui@huawei.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, sdonthineni@nvidia.com, alpergun@google.com, fj0570is@fujitsu.com, WeiLin.Chang@arm.com, lpieralisi@kernel.org, enju.kohei@fujitsu.com Subject: Re: [PATCH v18 2/7] firmware: arm_rmm: Check for RMI support at init Message-ID: <20260921143718.00001e55@oss.qualcomm.com> In-Reply-To: References: <20260912083611.2513845-1-suzuki.poulose@arm.com> <20260912083611.2513845-3-suzuki.poulose@arm.com> <178978126541.2352296.3637463397103730192.b4-review@b4> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: evNxIhmNhW0qGU46_PBenRYWhAUmBBiD X-Authority-Analysis: v=2.4 cv=B+0sQ+tM c=1 sm=1 tr=0 ts=6ab1a393 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=aNnz9XPx1a4JIXSYt2cE/A==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=7CQSdrXTAAAA:8 a=dENJxcbTWoohif9XLWkA:9 a=CjuIK1q_8ugA:10 a=324X-CrmTo6CU4MGRt3R:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIxMDMxNSBTYWx0ZWRfX1zM0BU9GJsPt 2w9Tz4MpgDO1JUW853w+PqBZ5N17EH2428kyePJ5wkPNsec/PE61jz2oMbxnrweIzSi9eIKGjRH 1KE+HY5TTWreNk8DG9In50PZdqgCUi8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIxMDMxNSBTYWx0ZWRfX26FtvIvuruvE esV5HzwrJ6P61F8PjvNUDwSoieujVhj+Xn8YesbEx3W4pb9Lh0OdNSmuVav7GQa49hncWfsy1o2 A5Cyke4eBPRUi5LJ26lx6Mz3x+RK7W7wdGHIvbaTjlcY/6Bb2t3W3WYw1d1Dlgv9dmo5hsv9V7Q q/w+6qk8HXxW3JsHdH6W8TSjlSLbOyLW5v/XmJ38N7FBf3BInlv1Y2ceENs6KObliueGooatUN1 owBaBeCwNk82ibveO4W0zqqJ84DZXvbFl1UYcXFrkHkUuS2Ig1oJIifaZDWLAds4s+zvqBCMoeI oRTmpZRHW3RsOj+HVjIUWjP8TKv2OZGBA8JWRO58MAtz/0of6+0Y6lIBNLtA/xm0neI+83E05d9 +yy4DLd9JrWLMt3k1/KlO46FFKvGFCOwx+5DDEATVrdusTsg9hV1R5pmO9LMc6qER4/TAW3i2v2 m7rsJYNqGQwvctuEwQg== X-Proofpoint-ORIG-GUID: evNxIhmNhW0qGU46_PBenRYWhAUmBBiD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-21_06,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609210315 On Mon, 21 Sep 2026 10:00:20 +0100 Suzuki K Poulose wrote: > On 19/09/2026 02:27, Jonathan Cameron wrote: > >> Query the RMI version number and check if it is a compatible version. > >> The first two feature registers are read and exposed for future code to > >> use. > >> > >> We only support this for Little Endian kernels, the Big Endian kernel > >> support is anyway marked BROKEN and is being removed. > > > > Can we have a small comment here on why the default is y > > > > It's a big thing to opt into by default. Feels like defconfig > > material maybe but not in the Kconfig defaults unless I'm missing > > something. > > We need this for KVM arm64. I could drop the default here and > KVM selects this anyways. But, how far do we go on this ? > Do we need to be able to disable this completely even for KVM ? Not sure. Question for the KVM folk to decide. Lot of pre CCA systems out there and domains in which CCA may not be useful, so definitely makes sense that people will build kernels without it. I think dropping this default though makes sense if KVM can select it. Jonathan > > As such it is a relatively smaller blob: > > $ size drivers/firmware/arm_rmm/rmi.o > text data bss dec hex filename > 7477 572 1 8050 1f72 drivers/firmware/arm_rmm/rmi.o > > Cheers > Suzuki >