From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E67C35646 for ; Fri, 21 Feb 2020 17:48:08 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 63244206E2 for ; Fri, 21 Feb 2020 17:48:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IAFhURPx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63244206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D7AFA4AEE0; Fri, 21 Feb 2020 12:48:07 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MdQztTvcMJm3; Fri, 21 Feb 2020 12:48:06 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DE7AD4AED6; Fri, 21 Feb 2020 12:48:06 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 996C44AED4 for ; Fri, 21 Feb 2020 12:48:05 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QcM8xExrGWdp for ; Fri, 21 Feb 2020 12:48:04 -0500 (EST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BBA944AECF for ; Fri, 21 Feb 2020 12:48:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582307284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RrMvZJoVJBWqnzqNr9KyLlzqZ46CEJlOdAIqg//g6XU=; b=IAFhURPxVTpM8k7fij5Loh0n4UD1VEj9uLkcRld2TW6q03gaVe+x6zO2ysGSOSVLIMyGN9 9akeOMcgv6Y19p27zyb2wil7NBmGibnpYTdZRFOsjblXmkJ1FJMwI5iMzK4aTM4+NnkklZ L5lGGVYNwZuXNhVVwzcmwnKRHn1gdu8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-4eMg5SRBOoeLC5LMhGQfNg-1; Fri, 21 Feb 2020 12:47:56 -0500 X-MC-Unique: 4eMg5SRBOoeLC5LMhGQfNg-1 Received: by mail-wr1-f70.google.com with SMTP id 90so1339725wrq.6 for ; Fri, 21 Feb 2020 09:47:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RrMvZJoVJBWqnzqNr9KyLlzqZ46CEJlOdAIqg//g6XU=; b=SLXXvEXWyBuumPpEuACT2uS+oCITKgozFW5jNCobtYwqxDfMg2UCw2xVlPIZvu5EHH C4HrN3EWEN5Qropbd1EQQTzGLqDkRJvPUIwuGutyQqXsfKO+ONZKnvJ/C+kmrCxf8sDB xqNJvvNIslPxOAhGGuUTolfwHwN9EZgnzaEO5V490P31MVTXT/Y4628sFpqWQ/MeJeul y641oN3z5jxkiy7pwFtLyCDpHf6pFTx808inF9IR2BECm+zyvWp5pGKZBfkEvH7hIxd3 VmmbjVP5VqyIbNIplsuajFK2DiWb/tMQ9S434YhFBUB8CTsrwLIWZq4UDM/HGMtLsfk1 Hrww== X-Gm-Message-State: APjAAAXoJ80mAfeJcpt3pfwZJJ1vvUfI2joOlbFYh8VppATwiI5xE9xu taG2JrYWEWYZgx/PXRqzops7yMqvE1rqhR6bVY/P5Jmv3YG8BUKQLSSHflF8T7OEHvWJM/orXRw N0BAS/TzzUTOS32lJCYmUkmNa X-Received: by 2002:adf:e68d:: with SMTP id r13mr49225912wrm.349.1582307275646; Fri, 21 Feb 2020 09:47:55 -0800 (PST) X-Google-Smtp-Source: APXvYqzI29TQnMTxhegOPTR5SZPy7HDTeZP8mdmwqeW3b3wvRv6t/VcN7GX1ZnOVCmuZ9M9Iv9A8Vg== X-Received: by 2002:adf:e68d:: with SMTP id r13mr49225876wrm.349.1582307275388; Fri, 21 Feb 2020 09:47:55 -0800 (PST) Received: from [192.168.178.40] ([151.20.135.128]) by smtp.gmail.com with ESMTPSA id x6sm4531952wmi.44.2020.02.21.09.47.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2020 09:47:54 -0800 (PST) Subject: Re: [PATCH v6 17/22] KVM: Terminate memslot walks via used_slots To: Sean Christopherson References: <20200218210736.16432-1-sean.j.christopherson@intel.com> <20200218210736.16432-18-sean.j.christopherson@intel.com> From: Paolo Bonzini Message-ID: <216d647a-e598-d5d6-e20f-9c44c9ca157f@redhat.com> Date: Fri, 21 Feb 2020 18:47:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200218210736.16432-18-sean.j.christopherson@intel.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , linux-mips@vger.kernel.org, Paul Mackerras , kvmarm@lists.cs.columbia.edu, Janosch Frank , Marc Zyngier , Joerg Roedel , Christian Borntraeger , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jim Mattson , Cornelia Huck , linux-kernel@vger.kernel.org, Vitaly Kuznetsov , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 18/02/20 22:07, Sean Christopherson wrote: > tmp = id_to_memslot(__kvm_memslots(kvm, as_id), id); > - old = *tmp; > - tmp = NULL; > + if (tmp) { > + old = *tmp; > + tmp = NULL; > + } else { > + memset(&old, 0, sizeof(old)); > + old.id = id; > + } > So much for my previous brilliant suggestion. :) Paolo _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm