From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 2/2] KVM: arm64: Drop __cpu_init_stage2 on the VHE path
Date: Mon, 1 Oct 2018 17:13:27 +0100 [thread overview]
Message-ID: <22605c91-53f1-239d-e6bf-1d9cf617bdbb@arm.com> (raw)
In-Reply-To: <20181001130656.36999-3-marc.zyngier@arm.com>
Marc,
On 10/01/2018 02:06 PM, Marc Zyngier wrote:
> __cpu_init_stage2 doesn't do anything anymore on arm64, and is
> totally non-sensical if running VHE (as VHE is 64bit only).
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> virt/kvm/arm/arm.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
> index 91c464c9cd21..4ce99bb223bc 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -1310,16 +1310,10 @@ static void cpu_hyp_reinit(void)
> {
> cpu_hyp_reset();
>
> - if (is_kernel_in_hyp_mode()) {
> - /*
> - * __cpu_init_stage2() is safe to call even if the PM
> - * event was cancelled before the CPU was reset.
> - */
> - __cpu_init_stage2();
> + if (is_kernel_in_hyp_mode())
> kvm_timer_init_vhe();
The patch looks good to me. However, if we ever add something there in
the future, this caller site could be lost. Is it worth a comment ?
Besides,
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
next prev parent reply other threads:[~2018-10-01 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 13:06 [PATCH 0/2] KVM: arm64: Dynamic IPA cosmetic fixups Marc Zyngier
2018-10-01 13:06 ` [PATCH 1/2] KVM: arm/arm64: Rename kvm_arm_config_vm to kvm_arm_setup_stage2 Marc Zyngier
2018-10-01 15:45 ` Suzuki K Poulose
2018-10-02 8:39 ` Auger Eric
2018-10-01 13:06 ` [PATCH 2/2] KVM: arm64: Drop __cpu_init_stage2 on the VHE path Marc Zyngier
2018-10-01 16:13 ` Suzuki K Poulose [this message]
2018-10-02 8:41 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22605c91-53f1-239d-e6bf-1d9cf617bdbb@arm.com \
--to=suzuki.poulose@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox