Re: [PATCH v3 44/47] arm_mpam: Add workaround for T241-MPAM-1

Ben Horgan
2026-01-19T20:54:26Z

Hi Gavin,

On 1/19/26 12:16, Gavin Shan wrote:
> On 1/13/26 12:59 AM, Ben Horgan wrote:

>>   +#define MPAM_IIDR_NVIDIA_T241
>> FIELD_PREP_CONST(MPAMF_IIDR_PRODUCTID,   0x241)    | \
>> +                FIELD_PREP_CONST(MPAMF_IIDR_VARIANT,     0)    | \
>> +                FIELD_PREP_CONST(MPAMF_IIDR_REVISION,    0)    | \
>> +                FIELD_PREP_CONST(MPAMF_IIDR_IMPLEMENTER, 0x36b)
>> +
>
> An error reported by checkpatch.pl as below.
>
> ERROR: Macros with complex values should be enclosed in parentheses
> #205: FILE: drivers/resctrl/mpam_internal.h:247:
> +#define MPAM_IIDR_NVIDIA_T241
> FIELD_PREP_CONST(MPAMF_IIDR_PRODUCTID,   0x241)    | \
> +                FIELD_PREP_CONST(MPAMF_IIDR_VARIANT,     0)    | \
> +                FIELD_PREP_CONST(MPAMF_IIDR_REVISION,    0)    | \
> +                FIELD_PREP_CONST(MPAMF_IIDR_IMPLEMENTER, 0x36b)

Fixed
>
>
>>   /* The values for MSMON_CFG_MBWU_FLT.RWBW */
>>   enum mon_filter_options {
>>       COUNT_BOTH    = 0,
>
> Thanks,
> Gavin
>

Thanks,

Ben