Re: [PATCH v3 37/47] arm_mpam: resctrl: Update the rmid reallocation limit

Shaopeng Tan (Fujitsu)
2026-01-15T10:05:52Z

Hello Ben,

> From: James Morse <james.morse@arm.com>
>
> resctrl's limbo code needs to be told when the data left in a cache is
> small enough for the partid+pmg value to be re-allocated.
>
> x86 uses the cache size divided by the number of rmid users the cache may
> have. Do the same, but for the smallest cache, and with the number of
> partid-and-pmg users.
>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
> ---
> Changes since v2:
> Move waiting for cache info into it's own patch
> ---
> drivers/resctrl/mpam_resctrl.c | 35 ++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/drivers/resctrl/mpam_resctrl.c b/drivers/resctrl/mpam_resctrl.c
> index 5adc78f9c96f..a6be3ce84241 100644
> --- a/drivers/resctrl/mpam_resctrl.c
> +++ b/drivers/resctrl/mpam_resctrl.c
> @@ -561,6 +561,38 @@ void resctrl_arch_reset_cntr(struct rdt_resource *r, struct rdt_mon_domain *d,
> reset_mon_cdp_safe(mon, mon_comp, USE_PRE_ALLOCATED, closid, rmid);
> }
>
> +/*
> + * The rmid realloc threshold should be for the smallest cache exposed to
> + * resctrl.
> + */
> +static int update_rmid_limits(struct mpam_class *class)
> +{
> + u32 num_unique_pmg = resctrl_arch_system_num_rmid_idx();
> + struct mpam_props *cprops = &class->props;
> + struct cacheinfo *ci;
> +
> + lockdep_assert_cpus_held();
> +
> + /* Assume cache levels are the same size for all CPUs... */
> + ci = get_cpu_cacheinfo_level(smp_processor_id(), class->level);
> + if (!ci || ci->size == 0) {
> + pr_debug("Could not read cache size for class %u\n",
> + class->level);
> + return -EINVAL;
> + }
> +
> + if (!mpam_has_feature(mpam_feat_msmon_csu, cprops))
> + return 0;

Shouldn't it be return -EOPNOTSUPP;?

However, before the function update_rmid_limits() is called, there is a check: if (cache_has_usable_csu(class) && topology_matches_l3(class)).
cache_has_usable_csu(class) already contains an identical check. Therefore, I think it's safe to remove this redundant one.

Best regards,
Shaopeng TAN

> + if (!resctrl_rmid_realloc_limit ||
> + ci->size < resctrl_rmid_realloc_limit) {
> + resctrl_rmid_realloc_limit = ci->size;
> + resctrl_rmid_realloc_threshold = ci->size / num_unique_pmg;
> + }
> +
> + return 0;
> +}
> +
> static bool cache_has_usable_cpor(struct mpam_class *class)
> {
> struct mpam_props *cprops = &class->props;
> @@ -1006,6 +1038,9 @@ static void mpam_resctrl_pick_counters(void)
> /* CSU counters only make sense on a cache. */
> switch (class->type) {
> case MPAM_CLASS_CACHE:
> + if (update_rmid_limits(class))
> + continue;
> +
> counter_update_class(QOS_L3_OCCUP_EVENT_ID, class);
> break;
> default:
> --
> 2.43.0