Re: [PATCH 3/6] firmware: arm_rmm: Check for RMI support at init

[Steven Price <steven.price@arm.com>]

On 15/07/2026 16:06, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The function `is_rmi_available()` is declared in the header but its implementation is missing.
> --
> 
> --- Patch [3]: [PATCH 3/6] firmware: arm_rmm: Check for RMI support at init ---
> commit 422535e6880c00ddffdc5f970e459e2cf571e957
> Author: Steven Price <steven.price@arm.com>
> 
> firmware: arm_rmm: Check for RMI support at init
> 
> Query the RMI version number and check if it is a compatible version.
> The first two feature registers are read and exposed for future code to
> use.
> 
>> diff --git a/drivers/firmware/arm_rmm/rmi.c b/drivers/firmware/arm_rmm/rmi.c
>> new file mode 100644
>> index 0000000000000..c4850976544ff
>> --- /dev/null
>> +++ b/drivers/firmware/arm_rmm/rmi.c
> 
> [ ... ]
> 
>> +static int __init arm64_init_rmi(void)
>> +{
>> +	int ret;
>> +
>> +	/* Continue without realm support if we can't agree on a version */
>> +	ret = rmi_check_version();
>> +	if (ret)
>> +		return ret;
>> +
>> +	ret = rmi_read_features();
>> +	if (ret)
>> +		return ret;
>> +
>> +	return 0;
>> +}
>> +
>> +/*
>> + * Note arm64_init_rmi() must be called before kvm_init_rmi() otherwise KVM
>> + * will not support realm guests. subsys_initcall() is called before
>> + * module_init() (used for KVM) so this is OK.
>> + */
>> +subsys_initcall(arm64_init_rmi);
> 
> [Severity: Low]
> Is the implementation of is_rmi_available() missing here?

Short answer: no.

Long answer - the previous patch added the definition and the following
patch adds the implementation. That's clearly wrong and I'll fix it.

Steve

> It is declared for external callers in include/linux/arm-rmi-cmds.h:
> 
> bool is_rmi_available(void);
> 
> However, the corresponding definition appears to be missing from
> drivers/firmware/arm_rmm/rmi.c, which could lead to link-time undefined
> reference errors when another subsystem attempts to use it.
>