Re: [PATCH v4 2/6] KVM: arm64: Add support for FEAT_HDBSS

[Tian Zheng <zhengtian10@huawei.com>]

On 7/9/2026 7:00 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The parameter name `cope` in `has_vhe_hdbss()` is a typo for `scope`.
> --
> 
> --- Patch [2]: [PATCH v4 2/6] KVM: arm64: Add support for FEAT_HDBSS ---
> commit fc8e5042a6724701835a3f111b45e733575a4a2e
> Author: Tian Zheng <zhengtian10@huawei.com>
> 
> KVM: arm64: Add support for FEAT_HDBSS
> 
> This commit adds CPU capability detection for the Hardware Dirty Bit State
> Structure (HDBSS) feature introduced in Armv9.5. It provides a helper
> function to check for hardware support, requiring VHE mode.
> 
>> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
>> index 9a22df0c5120f..aa327eebaf1ca 100644
>> --- a/arch/arm64/kernel/cpufeature.c
>> +++ b/arch/arm64/kernel/cpufeature.c
> [ ... ]
>> @@ -2131,6 +2131,11 @@ static bool hvhe_possible(const struct arm64_cpu_capabilities *entry,
>>   	return arm64_test_sw_feature_override(ARM64_SW_FEATURE_OVERRIDE_HVHE);
>>   }
>>   
>> +static bool has_vhe_hdbss(const struct arm64_cpu_capabilities *entry, int cope)
>                                                                               ^^^^
> 
> [Severity: Low]
> This isn't a bug, but is the parameter name "cope" a typo for "scope"?
> 
>> +{
>> +	return is_kernel_in_hyp_mode() && has_cpuid_feature(entry, cope);
>> +}
>> +
>>   bool cpu_supports_bbml2_noabort(void)
>>   {
> 

This has already been fixed in v5, where the parameter is correctly
named scope.

Thanks!
Tian