From: Shuah Khan <skhan@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] kselftest: kvm/arm64: Skip tests if we can't create a vgic-v3
Date: Wed, 26 Jan 2022 13:03:44 -0700 [thread overview]
Message-ID: <48c44d74-6668-7823-ada6-0285a8b32a35@linuxfoundation.org> (raw)
In-Reply-To: <YfGmk1I8l+ROoE/k@sirena.org.uk>
On 1/26/22 12:52 PM, Mark Brown wrote:
> On Wed, Jan 26, 2022 at 12:22:41PM -0700, Shuah Khan wrote:
>> On 1/26/22 7:52 AM, Mark Brown wrote:
>
>>> + ret = vgic_v3_setup(vm, nr_vcpus, 64, GICD_BASE_GPA, GICR_BASE_GPA);
>>> + if (ret < 0) {
>>> + print_skip("Failed to create vgic-v3");
>
>> Printing the negative error code returned by vgic_v3_setup will be useful.
>
> If the function fails for any reason other than the system not
> supporting vgic-v3 it will abort rather than return.
>
Hmm. vgic_v3_setup() return gic_fd looks like and the interface says
Return: GIC file-descriptor or negative error code upon failure
I don't follow the abort part.
thanks,
-- Shuah
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2022-01-27 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 14:52 [PATCH v3] kselftest: kvm/arm64: Skip tests if we can't create a vgic-v3 Mark Brown
2022-01-26 15:12 ` Andrew Jones
2022-01-26 19:22 ` Shuah Khan
2022-01-26 19:52 ` Mark Brown
2022-01-26 20:03 ` Shuah Khan [this message]
2022-01-26 20:13 ` Mark Brown
2022-01-26 20:50 ` Shuah Khan
2022-01-27 4:16 ` Ricardo Koller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48c44d74-6668-7823-ada6-0285a8b32a35@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox