Linux KVM/arm64 development list
 help / color / mirror / Atom feed
From: Alexandre Chartre <alexandre.chartre@oracle.com>
To: Marc Zyngier <maz@kernel.org>,
	linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu
Cc: kernel-team@android.com, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH 0/3] kvm-arm64: Fix PMU reset values (and more)
Date: Thu, 15 Jul 2021 10:34:03 +0200	[thread overview]
Message-ID: <54e98237-263c-1154-6223-88bbee6bdad8@oracle.com> (raw)
In-Reply-To: <20210713135900.1473057-1-maz@kernel.org>



On 7/13/21 3:58 PM, Marc Zyngier wrote:
> Hi all,
> 
> After some back and forth with Alexandre about patch #3 of this
> series, it became apparent that some of the PMU code paths perform
> some unnecessary masking, only to hide the fact that some of the PMU
> register reset values are not architecturally compliant (RES0 bits get
> set, among other things).
> 
> The first patch of this series addresses the reset value problem, the
> second one rids us of the pointless masking, and Alexandre's patch
> (which depends on the first two) is slapped on top, with a small
> cosmetic change.
> 

Thanks Marc.

You can add my Reviewed-by to patch 1 and 2:

Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>

alex.

> 
> Alexandre Chartre (1):
>    KVM: arm64: Disabling disabled PMU counters wastes a lot of time
> 
> Marc Zyngier (2):
>    KVM: arm64: Narrow PMU sysreg reset values to architectural
>      requirements
>    KVM: arm64: Drop unnecessary masking of PMU registers
> 
>   arch/arm64/kvm/pmu-emul.c |  8 +++---
>   arch/arm64/kvm/sys_regs.c | 52 ++++++++++++++++++++++++++++++++++-----
>   2 files changed, 50 insertions(+), 10 deletions(-)
> 
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

      parent reply	other threads:[~2021-07-15  8:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 13:58 [PATCH 0/3] kvm-arm64: Fix PMU reset values (and more) Marc Zyngier
2021-07-13 13:58 ` [PATCH 1/3] KVM: arm64: Narrow PMU sysreg reset values to architectural requirements Marc Zyngier
2021-07-13 14:39   ` Russell King (Oracle)
2021-07-13 15:59     ` Marc Zyngier
2021-07-13 16:15       ` Russell King (Oracle)
2021-07-14 15:48   ` Alexandru Elisei
2021-07-15 11:11     ` Marc Zyngier
2021-07-15 11:51       ` Robin Murphy
2021-07-15 12:25         ` Marc Zyngier
2021-07-13 13:58 ` [PATCH 2/3] KVM: arm64: Drop unnecessary masking of PMU registers Marc Zyngier
2021-07-14 16:12   ` Alexandru Elisei
2021-07-13 13:59 ` [PATCH 3/3] KVM: arm64: Disabling disabled PMU counters wastes a lot of time Marc Zyngier
2021-07-14 16:18   ` Alexandru Elisei
2021-07-15  8:34 ` Alexandre Chartre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54e98237-263c-1154-6223-88bbee6bdad8@oracle.com \
    --to=alexandre.chartre@oracle.com \
    --cc=kernel-team@android.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox