Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

Paolo Bonzini
2015-04-27T10:31:18Z

On 27/04/2015 10:26, Eric Auger wrote:
>> > One of my long term goals is to try and get rid of sysbus IRQ
>> > abstraction completely in favor of just qdev gpios. This means
>> > features that apply to GPIOs automatically apply to IRQs and vice
>> > versa. Can your notifier hook be pushed up to the qdev GPIO level to
>> > make it more globally usable and avoid a new feature to sysbus IRQs?
> Yes sure, I am going to put the notifier in DeviceClass then.

I've thought too about this, and I'm not sure about it.

It would mean you have to pass the gpio name (e.g.
SYSBUS_DEVICE_GPIO_IRQ) to the hook, and in the case of sysbus IRQs this
would leak the SYSBUS_DEVICE_GPIO_IRQ abstraction to the implementors of
the hook.

Paolo