Re: [PATCH 1/2] KVM: provide irq_unsafe kvm_guest_{enter|exit}

Paolo Bonzini
2015-04-30T12:19:58Z

On 30/04/2015 14:07, Christian Borntraeger wrote:
>>>>> >>>> +static inline void __kvm_guest_enter(void)
>>>>> >>>> {
>>>>> >>>> - unsigned long flags;
>>>>> >>>> -
>>>>> >>>> - BUG_ON(preemptible());
>>>> >>>
>>>> >>> Please keep the BUG_ON() in kvm_guest_enter. Otherwise looks good, thanks!
>> >
>> > Ah, you mean have the BUG_ON in the non underscore version? Yes, makes sense.
> Hmmm, too quick.
> the BUG_ON was there to make sure that rcu_virt_note_context_switch is safe.
> The reworked code pulls the rcu_virt_note_context_switch within the irq_save
> section so we no longer need this BUG_ON, no?

Right. I can apply the patches then!

Paolo