From: Julien Grall <julien.grall@arm.com>
To: Wei Huang <wei@redhat.com>, kvmarm@lists.cs.columbia.edu
Cc: christoffer.dall@linaro.org, marc.zyngier@arm.com,
fu.wei@linaro.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, al.stone@linaro.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 1/6] KVM: arm/arm64: arch_timer: Gather KVM specific information in a structure
Date: Fri, 19 Feb 2016 10:53:49 +0000 [thread overview]
Message-ID: <56C6F43D.3010503@arm.com> (raw)
In-Reply-To: <56C6C318.3000205@redhat.com>
Hello Wei,
On 19/02/16 07:24, Wei Huang wrote:
> On 02/11/2016 09:33 AM, Julien Grall wrote:
[...]
>> This is also dropping arch_timer_get_timecounter as it was only used by
>> the KVM code. Furthermore, a stub for the new helper hasn't been
>> introduced because KVM is requiring the arch timer for both ARM64 and
>> ARM32.
[...]
>> -static inline struct timecounter *arch_timer_get_timecounter(void)
>> -{
>> - return NULL;
>> -}
>> -
>
> Most parts are OK. Regarding removing this function from the #else area,
> is there a possibility to have CONFIG_ARM_ARCH_TIMER=n and CONFIG_KVM=y.
> If so, will the compilation fails here?
This patch is removing arch_timer_get_timecounter. So it's normal to
drop the stub in the #else area.
Furthermore, as mentioned in the commit message, I didn't add a stub for
the new function because KVM mandates the arch timer for both ARM64 and
ARM32.
Regards,
next prev parent reply other threads:[~2016-02-19 10:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 15:33 [PATCH v2 0/6] arm64: Add support of KVM with ACPI Julien Grall
2016-02-11 15:33 ` [PATCH v2 1/6] KVM: arm/arm64: arch_timer: Gather KVM specific information in a structure Julien Grall
2016-02-19 7:24 ` Wei Huang
2016-02-19 10:53 ` Julien Grall [this message]
2016-02-19 11:41 ` Julien Grall
2016-02-19 11:54 ` Marc Zyngier
2016-02-11 15:33 ` [PATCH v2 2/6] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables Julien Grall
2016-03-03 19:38 ` Christoffer Dall
2016-03-04 10:32 ` Julien Grall
2016-02-11 15:33 ` [PATCH v2 3/6] irqchip/gic-v2: Gather ACPI specific data in a single structure Julien Grall
2016-02-11 15:33 ` [PATCH v2 4/6] irqchip/gic-v2: Parse and export virtual GIC information Julien Grall
2016-02-11 15:33 ` [PATCH v2 5/6] irqchip/gic-v3: " Julien Grall
2016-02-11 15:33 ` [PATCH v2 6/6] KVM: arm/arm64: vgic: Rely on the GIC driver to parse the firmware tables Julien Grall
2016-02-19 6:36 ` [PATCH v2 0/6] arm64: Add support of KVM with ACPI Wei Huang
2016-02-23 2:31 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C6F43D.3010503@arm.com \
--to=julien.grall@arm.com \
--cc=al.stone@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=fu.wei@linaro.org \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox