From: Julien Grall <julien.grall@arm.com>
To: Shanker Donthineni <shankerd@codeaurora.org>,
kvmarm@lists.cs.columbia.edu
Cc: al.stone@linaro.org, kvm@vger.kernel.org, marc.zyngier@arm.com,
linux-kernel@vger.kernel.org, gg@slimlogic.co.uk,
linux-arm-kernel@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
fu.wei@linaro.org, Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information
Date: Mon, 11 Apr 2016 15:03:15 +0100 [thread overview]
Message-ID: <570BAEA3.5090007@arm.com> (raw)
In-Reply-To: <570868EE.9090200@codeaurora.org>
On 09/04/16 03:29, Shanker Donthineni wrote:
> Hi Julien,
Hello Shanker,
> On 04/04/2016 06:37 AM, Julien Grall wrote:
>> +static int __init gic_acpi_parse_virt_madt_gicc(struct
>> acpi_subtable_header *header,
>> + const unsigned long end)
>> +{
>> + struct acpi_madt_generic_interrupt *gicc =
>> + (struct acpi_madt_generic_interrupt *)header;
>> + int maint_irq_mode;
>> + static int first_madt = true;
>> +
>> + maint_irq_mode = (gicc->flags & ACPI_MADT_VGIC_IRQ_MODE) ?
>> + ACPI_EDGE_SENSITIVE : ACPI_LEVEL_SENSITIVE;
>> +
> Do you think GICC parameters are valid for an unusable processor?
Good point. We don't know if the value will be valid when the processor
is unusable.
> If not we need a validation check here, some thing like this to skip
> GICC subtable entry.
>
> if (!(gicc->flags & ACPI_MADT_ENABLED))
> return 0;
I will add this check.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2016-04-11 14:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 11:37 [PATCH v5 0/9] arm64: Add support for KVM with ACPI Julien Grall
2016-04-04 11:37 ` [PATCH v5 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure Julien Grall
2016-04-06 17:26 ` Christoffer Dall
2016-04-04 11:37 ` [PATCH v5 2/9] clocksource: arm_arch_timer: Extend arch_timer_kvm_info to get the virtual IRQ Julien Grall
2016-04-06 17:26 ` Christoffer Dall
2016-04-04 11:37 ` [PATCH v5 3/9] irqchip/gic-v2: Gather ACPI specific data in a single structure Julien Grall
2016-04-11 2:47 ` Hanjun Guo
2016-04-04 11:37 ` [PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC information Julien Grall
2016-04-06 17:04 ` Christoffer Dall
2016-04-06 17:40 ` Julien Grall
2016-04-11 3:17 ` Hanjun Guo
2016-04-11 13:54 ` Julien Grall
2016-04-04 11:37 ` [PATCH v5 5/9] irqchip/gic-v3: Gather all ACPI specific data in a single structure Julien Grall
2016-04-06 17:26 ` Christoffer Dall
2016-04-11 5:21 ` Hanjun Guo
2016-04-04 11:37 ` [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information Julien Grall
2016-04-06 17:22 ` Christoffer Dall
2016-04-06 17:45 ` Julien Grall
2016-04-09 2:29 ` Shanker Donthineni
2016-04-11 14:03 ` Julien Grall [this message]
2016-04-11 5:27 ` Hanjun Guo
2016-04-11 14:27 ` Julien Grall
2016-04-11 15:25 ` Shanker Donthineni
2016-04-13 10:11 ` Hanjun Guo
2016-04-04 11:37 ` [PATCH v5 7/9] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables Julien Grall
2016-04-04 11:37 ` [PATCH v5 8/9] KVM: arm/arm64: vgic: Rely on the GIC driver " Julien Grall
2016-04-06 17:25 ` Christoffer Dall
2016-04-04 11:37 ` [PATCH v5 9/9] clocksource: arm_arch_timer: Remove arch_timer_get_timecounter Julien Grall
2016-04-06 17:28 ` [PATCH v5 0/9] arm64: Add support for KVM with ACPI Christoffer Dall
2016-04-06 17:49 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570BAEA3.5090007@arm.com \
--to=julien.grall@arm.com \
--cc=al.stone@linaro.org \
--cc=fu.wei@linaro.org \
--cc=gg@slimlogic.co.uk \
--cc=jason@lakedaemon.net \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=shankerd@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox