From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Zhao Subject: Re: [PATCH 0/2] Add the missing resetting LRs at boot time for new-vgic Date: Wed, 7 Dec 2016 15:45:52 +0800 Message-ID: <5847BE30.9050701@huawei.com> References: <1481006504-25460-1-git-send-email-zhaoshenglong@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 44E59403F8 for ; Wed, 7 Dec 2016 02:47:43 -0500 (EST) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m0bOMgpx-VYK for ; Wed, 7 Dec 2016 02:47:36 -0500 (EST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [119.145.14.66]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 601DA401BF for ; Wed, 7 Dec 2016 02:47:34 -0500 (EST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Marc Zyngier , kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org List-Id: kvmarm@lists.cs.columbia.edu On 2016/12/6 19:47, Marc Zyngier wrote: > On 06/12/16 06:41, Shannon Zhao wrote: >> From: Shannon Zhao >> >> Commit 50926d8(KVM: arm/arm64: The GIC is dead, long live the GIC) >> removes the old vgic and commit 9097773(KVM: arm/arm64: vgic-new: >> vgic_init: implement kvm_vgic_hyp_init) doesn't reset LRs for new-vgic >> when probing GIC. These two patches add the missing part. >> >> BTW, here is a strange problem on Huawei D03 board when using >> upstream kernel that android guest with a goldfish_fb will hang with >> rcu_stall and interrupt timeout for goldfish_fb. We apply these patches >> but the problem still exists, while if we revert the commit >> b40c489(arm64: KVM: vgic-v3: Only wipe LRs on vcpu exit) the guest runs >> well. >> >> We add a trace in kvm_vgic_flush_hwstate() to print the value of >> compute_ap_list_depth(vcpu) and the value of vgic_lr before calling >> vgic_flush_lr_state(). The first output shows that the ap_list_depth is zero >> but the first one in vgic_lr is 10a0000000002001. I don't understand why >> there is a valued one in vgic_lr since the memory of vgic_lr is zero >> allocated. I think It should be zero when the vcpu first run and first >> call kvm_vgic_flush_hwstate(). >> >> qemu-system-aar-6673 [016] .... 501.969251: kvm_vgic_flush_hwstate: VCPU: 0, lits-count: 0, LR: 10a0000000002001, 0, 0, 0 >> >> I also add a trace at the end of vgic_flush_lr_state() which shows the >> kvm_vgic_global_state.nr_lr is 4, used_lrs is 0 and all LRs in vgic_lr >> are zero. >> >> qemu-system-aar-6673 [016] .... 501.969254: vgic_flush_lr_state_nuke: kvm_vgic_global_state.nr_lr is :4, irq1:0, irq2:0, irq3:0, irq4:0 >> >> But the trace at the beginning of kvm_vgic_sync_hwstate() shows the >> first one of vgic_lr is 10a0000000002001. >> >> qemu-system-aar-6673 [016] .... 501.969261: kvm_vgic_sync_hwstate_vgic_lr: VCPU: 0, used_lrs: 0, LR: 10a0000000002001, 0, 0, 0 >> >> The above three trace outputs are printed by the first KVM_ENTRY/EXIT of VCPU 0. > > Decoding this LR value is interesting: > > 10a0000000002001 > | | | LPI 8193 > | | > | Priority 0xa0 > | > Group1 > > Someone is injecting an LPI behind your back. If nobody populates this, > then you may want to investigate what is happening on the host side. Is > there anyone using this interrupt? > For this guest, I think nobody populates this LR, but on the host, there is a LPI interrupt 8193. It's a interrupt of eth2 MBIGEN-V2 8193 Edge eth2-tx0 It's a little confused to me that the LR registers should only be used for VM, right? Why does the interrupt on host would affect the LRs? Thanks, -- Shannon