public inbox for kvmarm@lists.cs.columbia.edu
 help / color / mirror / Atom feed
From: James Morse <james.morse@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: devicetree@vger.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Rob Herring <robh+dt@kernel.org>, Loc Ho <lho@apm.com>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 10/13] firmware: arm_sdei: Add support for CPU and system power states
Date: Tue, 17 Oct 2017 17:34:38 +0100	[thread overview]
Message-ID: <59E6311E.7030406@arm.com> (raw)
In-Reply-To: <20171016135204.ncz6fzw5gh3gv57c@armageddon.cambridge.arm.com>

Hi Catalin,

On 16/10/17 14:52, Catalin Marinas wrote:
> On Fri, Sep 22, 2017 at 07:26:11PM +0100, James Morse wrote:
>> diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
>> index f24bfb2b9a2d..466b949474df 100644
>> --- a/include/linux/cpuhotplug.h
>> +++ b/include/linux/cpuhotplug.h
>> @@ -88,6 +88,7 @@ enum cpuhp_state {
>>  	CPUHP_AP_PERF_XTENSA_STARTING,
>>  	CPUHP_AP_PERF_METAG_STARTING,
>>  	CPUHP_AP_MIPS_OP_LOONGSON3_STARTING,
>> +	CPUHP_AP_SDEI_STARTING,
> 
> Nitpick: how generic is this as to apply to other architectures?
> Probably not, so shall we prefix this with ARM_?

This may get used on 32bit ARM. I blindly copied PSCI, which doesn't have a
prefix. But it makes sense to have one.


> Not actually a strong preferences but similar question for the
> definitions in the sdei.h files (and maybe the filenames themselves).


Thanks,

James

  reply	other threads:[~2017-10-17 16:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 18:26 [PATCH v3 00/13] arm64/firmware: Software Delegated Exception Interface James Morse
2017-09-22 18:26 ` [PATCH v3 09/13] arm64: kernel: Add arch-specific SDEI entry code and CPU masking James Morse
2017-10-16 13:41   ` Catalin Marinas
     [not found]     ` <20171016134139.sqe6xabdson2d5rd-+1aNUgJU5qkijLcmloz0ER/iLCjYCKR+VpNB7YpNyf8@public.gmane.org>
2017-10-17 16:34       ` James Morse
     [not found]         ` <59E63105.9080804-5wv7dgnIgG8@public.gmane.org>
2017-10-18 10:54           ` Catalin Marinas
     [not found] ` <20170922182614.27885-1-james.morse-5wv7dgnIgG8@public.gmane.org>
2017-09-22 18:26   ` [PATCH v3 01/13] KVM: arm64: Store vcpu on the stack during __guest_enter() James Morse
2017-09-22 18:26   ` [PATCH v3 02/13] KVM: arm/arm64: Convert kvm_host_cpu_state to a static per-cpu allocation James Morse
2017-09-22 18:26   ` [PATCH v3 03/13] KVM: arm64: Change hyp_panic()s dependency on tpidr_el2 James Morse
2017-09-22 18:26   ` [PATCH v3 04/13] arm64: alternatives: use tpidr_el2 on VHE hosts James Morse
     [not found]     ` <20170922182614.27885-5-james.morse-5wv7dgnIgG8@public.gmane.org>
2017-10-13 15:31       ` Catalin Marinas
     [not found]         ` <20171013153148.dnejsvhxeui6opfw-+1aNUgJU5qkijLcmloz0ER/iLCjYCKR+VpNB7YpNyf8@public.gmane.org>
2017-10-13 16:50           ` James Morse
     [not found]             ` <59E0EEE5.2020208-5wv7dgnIgG8@public.gmane.org>
2017-10-16  9:58               ` Catalin Marinas
     [not found]                 ` <20171016095845.htg2g4jkyw3nvzub-+1aNUgJU5qkijLcmloz0ER/iLCjYCKR+VpNB7YpNyf8@public.gmane.org>
2017-10-17 16:36                   ` James Morse
2017-10-16 10:17     ` Catalin Marinas
2017-09-22 18:26   ` [PATCH v3 05/13] KVM: arm64: Stop save/restoring host tpidr_el1 on VHE James Morse
2017-09-22 18:26   ` [PATCH v3 06/13] Docs: dt: add devicetree binding for describing arm64 SDEI firmware James Morse
2017-09-22 18:26   ` [PATCH v3 07/13] firmware: arm_sdei: Add driver for Software Delegated Exceptions James Morse
2017-10-13 15:49     ` Catalin Marinas
2017-09-22 18:26   ` [PATCH v3 08/13] arm64: Add vmap_stack header file James Morse
     [not found]     ` <20170922182614.27885-9-james.morse-5wv7dgnIgG8@public.gmane.org>
2017-10-13 15:42       ` Catalin Marinas
     [not found]         ` <20171013154226.xswo4y2viht22wvk-+1aNUgJU5qkijLcmloz0ER/iLCjYCKR+VpNB7YpNyf8@public.gmane.org>
2017-10-17 16:34           ` James Morse
2017-09-22 18:26   ` [PATCH v3 10/13] firmware: arm_sdei: Add support for CPU and system power states James Morse
     [not found]     ` <20170922182614.27885-11-james.morse-5wv7dgnIgG8@public.gmane.org>
2017-10-16 13:52       ` Catalin Marinas
2017-10-17 16:34         ` James Morse [this message]
2017-09-22 18:26   ` [PATCH v3 11/13] firmware: arm_sdei: add support for CPU private events James Morse
2017-09-22 18:26   ` [PATCH v3 12/13] arm64: acpi: Remove __init from acpi_psci_use_hvc() for use by SDEI James Morse
2017-09-22 18:26   ` [PATCH v3 13/13] firmware: arm_sdei: Discover SDEI support via ACPI James Morse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59E6311E.7030406@arm.com \
    --to=james.morse@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=lho@apm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marc.zyngier@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox