From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 570E5C433E0 for ; Wed, 27 Jan 2021 17:56:25 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 947EA64DA8 for ; Wed, 27 Jan 2021 17:56:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 947EA64DA8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B05C14B377; Wed, 27 Jan 2021 12:56:23 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FkwijqQz8DAg; Wed, 27 Jan 2021 12:56:22 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AFEB94B378; Wed, 27 Jan 2021 12:56:22 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3290C4B375 for ; Wed, 27 Jan 2021 12:56:21 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1EfOcQ8qdEfz for ; Wed, 27 Jan 2021 12:56:20 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 23FBF4B2EC for ; Wed, 27 Jan 2021 12:56:20 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611770180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YgG+QDM5pkstFzGqV9mKJs9XdzX4nzUkQb+n0L09tGQ=; b=JnQLXsx8Q08Tl1no9tm+aTzrXEVA3RUSYyzb0uIQeqrRwPJWaKyWgCeq88QngPb63puJJW RJcer8X4SW8a+Gtm8nBOSSF9ELO3J7GoxGBAyloB6vSlmaXKUrNQR+qauDbJVi96t7LpJ9 SRXgLsYYfGKDA6Wkjacp9BjrF+aVzSc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-7m70NSHFOzyDteCqWKt7vA-1; Wed, 27 Jan 2021 12:56:18 -0500 X-MC-Unique: 7m70NSHFOzyDteCqWKt7vA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5659D801FCC; Wed, 27 Jan 2021 17:56:16 +0000 (UTC) Received: from [10.36.113.217] (ovpn-113-217.ams2.redhat.com [10.36.113.217]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 095AD60BF3; Wed, 27 Jan 2021 17:56:13 +0000 (UTC) Subject: Re: [PATCH v2 7/7] KVM: arm64: Use symbolic names for the PMU versions To: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org References: <20210125122638.2947058-1-maz@kernel.org> <20210125122638.2947058-8-maz@kernel.org> From: Auger Eric Message-ID: <6c6252b9-405e-ca35-4be2-8c1e646ce64b@redhat.com> Date: Wed, 27 Jan 2021 18:56:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20210125122638.2947058-8-maz@kernel.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Cc: kernel-team@android.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Marc, On 1/25/21 1:26 PM, Marc Zyngier wrote: > Instead of using a bunch of magic numbers, use the existing definitions > that have been added since 8673e02e58410 ("arm64: perf: Add support > for ARMv8.5-PMU 64-bit counters") > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/pmu-emul.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c > index 72cd704a8368..cb16ca2eee92 100644 > --- a/arch/arm64/kvm/pmu-emul.c > +++ b/arch/arm64/kvm/pmu-emul.c > @@ -23,11 +23,11 @@ static void kvm_pmu_stop_counter(struct kvm_vcpu *vcpu, struct kvm_pmc *pmc); > static u32 kvm_pmu_event_mask(struct kvm *kvm) > { > switch (kvm->arch.pmuver) { > - case 1: /* ARMv8.0 */ > + case ID_AA64DFR0_PMUVER_8_0: > return GENMASK(9, 0); > - case 4: /* ARMv8.1 */ > - case 5: /* ARMv8.4 */ > - case 6: /* ARMv8.5 */ > + case ID_AA64DFR0_PMUVER_8_1: > + case ID_AA64DFR0_PMUVER_8_4: > + case ID_AA64DFR0_PMUVER_8_5: > return GENMASK(15, 0); > default: /* Shouldn't be here, just for sanity */ > WARN_ONCE(1, "Unknown PMU version %d\n", kvm->arch.pmuver); > Reviewed-by: Eric Auger Thanks Eric _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm