From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 26CDC25D546 for ; Mon, 13 Oct 2025 16:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760372060; cv=none; b=S06dnafGgMfRR377Y5qGhq+XNkJjj73VYD5LYz8VtxqIetrLRnNlDS6V0s5UAMr/wBTx/W8jUsw3R416djUOqgHH+R+LUuSVxUyS5T7PBFcNuiDKX8DOgamGkZ1LAR9XAp93OGgAHaurUnB5ignYqyQH73KAkqP/LFDwb3d+rzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760372060; c=relaxed/simple; bh=zUCAV8CPpFSrgTn4UQQPBM784hXZgomTmf3YnQwkLm4=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=nkrRSNlPVB+HDss70uIsmavZj/6NYy/FxfMahdFSywlLvE6bkJhExm+HJr2BUwIZIXA78qGz4OUQbgO1nn53Yf/wQM1yOHVg2j5I+cpfxjNYZjLy5j2tiKMb4WV6OBMhOXoRwxqUT9AlBp2zrlJlgq7/VgczLLxH8XL2LOoD0ig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4741F113E; Mon, 13 Oct 2025 09:14:09 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2BD2D3F738; Mon, 13 Oct 2025 09:14:16 -0700 (PDT) Message-ID: <75f13087-80fa-45cb-9327-aa85522203e0@arm.com> Date: Mon, 13 Oct 2025 17:14:14 +0100 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] KVM: arm64: selftests: Sync ID_AA64PFR1, MPIDR, CLIDR in guest From: Ben Horgan To: Zenghui Yu , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Cc: maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com References: <20251012154352.61133-1-zenghui.yu@linux.dev> <25a19af8-2026-45b6-8d0f-42c371c8ff95@arm.com> Content-Language: en-US In-Reply-To: <25a19af8-2026-45b6-8d0f-42c371c8ff95@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/13/25 13:20, Ben Horgan wrote: > Hi Zenghui, > > On 10/12/25 16:43, Zenghui Yu wrote: >> We forgot to sync several registers (ID_AA64PFR1, MPIDR, CLIDR) in guest to >> make sure that the guest had seen the written value. >> >> Add them to the list. >> >> Signed-off-by: Zenghui Yu >> --- >> tools/testing/selftests/kvm/arm64/set_id_regs.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tools/testing/selftests/kvm/arm64/set_id_regs.c b/tools/testing/selftests/kvm/arm64/set_id_regs.c >> index 8ff1e853f7f8..5e24f77868b5 100644 >> --- a/tools/testing/selftests/kvm/arm64/set_id_regs.c >> +++ b/tools/testing/selftests/kvm/arm64/set_id_regs.c >> @@ -249,11 +249,14 @@ static void guest_code(void) >> GUEST_REG_SYNC(SYS_ID_AA64ISAR2_EL1); >> GUEST_REG_SYNC(SYS_ID_AA64ISAR3_EL1); >> GUEST_REG_SYNC(SYS_ID_AA64PFR0_EL1); >> + GUEST_REG_SYNC(SYS_ID_AA64PFR1_EL1); >> GUEST_REG_SYNC(SYS_ID_AA64MMFR0_EL1); >> GUEST_REG_SYNC(SYS_ID_AA64MMFR1_EL1); >> GUEST_REG_SYNC(SYS_ID_AA64MMFR2_EL1); >> GUEST_REG_SYNC(SYS_ID_AA64MMFR3_EL1); >> GUEST_REG_SYNC(SYS_ID_AA64ZFR0_EL1); >> + GUEST_REG_SYNC(SYS_MPIDR_EL1); >> + GUEST_REG_SYNC(SYS_CLIDR_EL1); > > Why did you choose this position in the list for these 2? > >> GUEST_REG_SYNC(SYS_CTR_EL0); >> GUEST_REG_SYNC(SYS_MIDR_EL1); >> GUEST_REG_SYNC(SYS_REVIDR_EL1); > > Looks good to me. > > Reviewed-By: Ben Horgan > Thanks, > > Ben > On running this, I note test_guest_reg_read() doesn't announce its presence. How about adding a ksft_test_result_pass("%s\n", __func__) and bumping the number of tests? Thanks, Ben